Differential D9362

Fix T82155: Fade inactive geometry overlay not working with instanced geometry
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 27 2020, 5:58 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T82155: Overlay setting "Fade Inactive Geometry" does not work with instance collections.

Commits

rBce62d650945f: Fix T82155: Fade inactive geometry overlay not working with instanced geometry

Summary

This enables the overlay for instanced geometry.

After this change, objects that are an instance of the current active
object (which are also being modified in the current active mode) won't
fade, which is different from the previous behavior.

Diff Detail

Repository

rB Blender

Branch

T82155 (branched from master)

Build Status

Buildable 10943
Build 10943: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 27 2020, 5:58 PM

Pablo Dobarro (pablodp606) created this revision.

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 27 2020, 5:58 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Harbormaster completed remote builds in B10943: Diff 30425.Oct 27 2020, 5:59 PM

Sergey Sharybin (sergey) edited reviewers, added: Clément Foucault (fclem); removed: Sergey Sharybin (sergey).Oct 27 2020, 6:21 PM

No strong opinion here.

This revision is now accepted and ready to land.Oct 28 2020, 3:45 AM

Philipp Oeser (lichtwerk) mentioned this in D9363: Fix T82155: Overlay setting "Fade Inactive Geometry" does not work with instances.Oct 28 2020, 3:43 PM

@Pablo Dobarro (pablodp606) : why not commit this? This has come up again, see T88133: No fading for instanced objects, when I use edit or sculpt modes

Closed by commit rBce62d650945f: Fix T82155: Fade inactive geometry overlay not working with instanced geometry (authored by Pablo Dobarro (pablodp606)). · Explain WhyMay 11 2021, 12:19 AM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBce62d650945f: Fix T82155: Fade inactive geometry overlay not working with instanced geometry.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_engine.c

4 lines

Diff 30425

View Options

source/blender/draw/engines/overlay/overlay_engine.c

Fix T82155: Fade inactive geometry overlay not working with instanced geometryClosedPublicActions