Differential D9372

macOS: use -fno-strict-aliasing for all build types.
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Oct 28 2020, 3:13 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBfc6a1f44d2ed: macOS: use -fno-strict-aliasing for all build types.

Summary

The old code was added in rBbaa4a9c7d4dd: CMake/OSX: remove gcc arguments conflicts raising warnings when building in…

While the hotfix committed in rB336a675c6442485f45dc52de1770ad4 fixed
the id_management test, the correct reason was found at
https://bugs.llvm.org/show_bug.cgi?id=47984

Diff Detail

Repository

rB Blender

Branch

aliasing (branched from master)

Build Status

Buildable 10958
Build 10958: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Oct 28 2020, 3:13 PM

Ankit Meel (ankitm) created this revision.

Harbormaster completed remote builds in B10958: Diff 30452.Oct 28 2020, 3:13 PM

Should this be in 2.91 also ?

Ankit Meel (ankitm) added a reviewer: Brecht Van Lommel (brecht).Oct 28 2020, 3:23 PM

For consistency with platform_unix.cmake, -fno-strict-aliasing can be added to PLATFORM_CFLAGS.

This should be committed to the blender-v2.91-release branch.

The workaround using volatile should also be removed.

Use PLATFORM_CFLAGS, not add_compile_options.

Will remove volatile in a follow up commit.

Harbormaster completed remote builds in B10961: Diff 30456.Oct 28 2020, 3:47 PM

Brecht Van Lommel (brecht) accepted this revision.Oct 28 2020, 3:58 PM

This revision is now accepted and ready to land.Oct 28 2020, 3:58 PM

Ankit Meel (ankitm) mentioned this in rB30ec0753c75c: Revert "Fix T81077 id_management test on macOS".Oct 28 2020, 4:43 PM

https://developer.blender.org/rBfc6a1f44d2ed6b3f793cbdc806d7030d6ddac2c3

Revision Contents
Changeset List

Path

Size

build_files/

cmake/

platform/

platform_apple.cmake

10 lines

Diff 30452

View Options

build_files/cmake/platform/platform_apple.cmake

macOS: use -fno-strict-aliasing for all build types.ClosedPublicActions