Fix T82188: Sculpt Grab Silhouette and symmetry fails
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 28 2020, 3:15 PM.

Details

Reviewers

Pablo Dobarro (pablodp606)
Sergey Sharybin (sergey)

Maniphest Tasks

T82188: Sculpt: Grag Silhouette and mirror error

Commits

rB440ed3ade884: Fix T82188: Sculpt Grab Silhouette and symmetry fails

Summary

Wasnt checking the symmetrized 'grab_delta_symmetry' so result could
flip around.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 28 2020, 3:15 PM

Harbormaster completed remote builds in B10959: Diff 30453.Oct 28 2020, 3:16 PM

Philipp Oeser (lichtwerk) requested review of this revision.Oct 28 2020, 3:16 PM

note: original code [even without symmetry] can pop/flip in certain cases, not sure if this is related to using initial_normal -- but that is a bit OT here I guess.

Pablo Dobarro (pablodp606) accepted this revision.Oct 28 2020, 4:12 PM

This revision is now accepted and ready to land.Oct 28 2020, 4:12 PM

Closed by commit rB440ed3ade884: Fix T82188: Sculpt Grab Silhouette and symmetry fails (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 29 2020, 9:49 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB440ed3ade884: Fix T82188: Sculpt Grab Silhouette and symmetry fails.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

sculpt.c

2 lines

Diff 30489

View Options

source/blender/editors/sculpt_paint/sculpt.c

Fix T82188: Sculpt Grab Silhouette and symmetry failsClosedPublicActions