Page MenuHome
Differential D9375

Breakdown Implementation
ClosedPublic
Actions

Authored by Christoph Lendenfeld (ChrisLend) on Oct 28 2020, 4:49 PM.
Tags
Subscribers
RedMser (RedMser)
Wayde Moss (GuiltyGhost)
Tokens
"Like" token, awarded by shader."Love" token, awarded by Stan1."Like" token, awarded by erickblender."Love" token, awarded by Juangra_Membata.

Details

Reviewers
Wayde Moss (GuiltyGhost)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T81785: Implementation: Modal Key Manipulation Operators
Commits
rBf7ddb1ed8a2a: Breakdown Implementation
Summary

This patch adds the breakdown (or tween) functionality to the graph editor.

The factor defines the linear interpolation from left key to right key.

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Oct 28 2020, 4:49 PM
Christoph Lendenfeld (ChrisLend) created this revision.
Christoph Lendenfeld (ChrisLend) added a task: T81785: Implementation: Modal Key Manipulation Operators.Oct 28 2020, 4:55 PM
Christoph Lendenfeld (ChrisLend) mentioned this in T81785: Implementation: Modal Key Manipulation Operators.
Luciano Muñoz Sessarego (looch) awarded a token.Oct 28 2020, 5:04 PM
Luciano Muñoz Sessarego (looch) rescinded a token.
RedMser (RedMser) added a subscriber: RedMser (RedMser).Oct 31 2020, 12:56 PM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 31105.Nov 15 2020, 9:56 PM

rebase

Wayde Moss (GuiltyGhost) added a subscriber: Wayde Moss (GuiltyGhost).Dec 14 2020, 6:51 AM
Wayde Moss (GuiltyGhost) added a reviewer: Wayde Moss (GuiltyGhost). Wayde Moss (GuiltyGhost) added 1 blocking reviewer(s): Animation & Rigging.Dec 22 2020, 11:40 PM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 45961.Dec 12 2021, 12:43 PM
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)
Christoph Lendenfeld (ChrisLend) edited reviewers, added: Sybren A. Stüvel (sybren); removed: Animation & Rigging.
  • update to latest master
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)Dec 12 2021, 12:46 PM
Sybren A. Stüvel (sybren) requested changes to this revision.Dec 13 2021, 4:01 PM

LGTM apart from the memory leak. The code will likely also have to be updated based on the change I mentioned in D13531.

source/blender/editors/space_graph/graph_slider_ops.c
695–699

I think this has the same memory leak as in D9374, add a call to BLI_freelistN(&segments);

This revision now requires changes to proceed.Dec 13 2021, 4:01 PM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 46095.Dec 15 2021, 11:43 PM
  • fix memory leak
  • adapt way of getting segment list after changes to D13531
  • pass FCurveSegment
Juan Gabriel (Juangra_Membata) awarded a token.Dec 16 2021, 12:15 AM
Erick Tukuniata (erickblender) awarded a token.Dec 16 2021, 12:18 AM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 46151.Dec 17 2021, 9:48 AM
  • add operator to menu
Sybren A. Stüvel (sybren) accepted this revision.Dec 17 2021, 5:51 PM
This revision is now accepted and ready to land.Dec 17 2021, 5:51 PM
Stanislav Ovcharov (Stan1) awarded a token.Dec 17 2021, 8:12 PM
Closed by commit rBf7ddb1ed8a2a: Breakdown Implementation (authored by Christoph Lendenfeld (ChrisLend)). · Explain WhyDec 25 2021, 8:59 PM
This revision was automatically updated to reflect the committed changes.
Christoph Lendenfeld (ChrisLend) added a commit: rBf7ddb1ed8a2a: Breakdown Implementation.
Bataev Artem (shader) awarded a token.Dec 29 2021, 8:44 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
12 lines
include/
3 lines
space_graph/
1 line
1 line
123 lines

Diff 46095

View Options

source/blender/editors/animation/keyframes_general.c

Loading...
View Options

source/blender/editors/include/ED_keyframes_edit.h

Loading...
View Options

source/blender/editors/space_graph/graph_intern.h

Loading...
View Options

source/blender/editors/space_graph/graph_ops.c

Loading...
View Options

source/blender/editors/space_graph/graph_slider_ops.c

Loading...