Sculpt: Dyntopo detail aware smoothing
Changes PlannedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 29 2020, 7:20 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Julien Kaspar (JulienKaspar)
Daniel Bystedt (dbystedt)

Summary

This implements a different smooth algorithm for dyntopo. This smooth
algorithm takes the current dyntopo detail size into account and tries
to smooth the whole mesh as it has that detail applied.

New:

Old (regular laplacian smooth):

This fixes the smoothing artifacts and bad deformation that regular
laplacian smoothing creates as areas with lower detail resolution will
smooth faster.

Dyntopo now uses this smooth algorithm by default automatically, but it
can be also added as an option. Its strength can also be tweaked
independently.

Diff Detail

Repository

rB Blender

Branch

dyntopo-detail-aware-smoothing (branched from master)

Build Status

Buildable 11054
Build 11054: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 29 2020, 7:20 PM

Harbormaster completed remote builds in B10981: Diff 30509.Oct 29 2020, 7:20 PM

Pablo Dobarro (pablodp606) requested review of this revision.Oct 29 2020, 7:20 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 29 2020, 7:22 PM

Pablo Dobarro (pablodp606) added reviewers: Sergey Sharybin (sergey), Julien Kaspar (JulienKaspar), Daniel Bystedt (dbystedt).

Matt (Kickflipkid687) awarded a token.Oct 29 2020, 7:36 PM

YAFU (YAFU) awarded a token.Oct 29 2020, 7:51 PM

Tiago Cruz (tiagoffcruz) awarded a token.Oct 29 2020, 8:14 PM

Tiago Cruz (tiagoffcruz) added a subscriber: Tiago Cruz (tiagoffcruz).

serge (rpserge) awarded a token.Oct 29 2020, 8:23 PM

It would also be a good idea to have this available for meshes and Multires, but this algorithm needs a know detail size in order to work. It is not clear to me how to decide the detail size for meshes and multires (maybe the average of the edge length of the whole mesh?)

Sergey Sharybin (sergey) requested changes to this revision.Oct 30 2020, 9:49 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/blenkernel/intern/pbvh_bmesh.c
2118	Either parenthesis is missing, or it is not an average.
source/blender/editors/sculpt_paint/sculpt_smooth.c
65	There is a missing explanation of how it is different from `SCULPT_neighbor_coords_average_interior`, when it can/should be used. Same applies to the `SCULPT_neighbor_coords_average_interior`.

This revision now requires changes to proceed.Oct 30 2020, 9:49 AM

Julien Kaspar (JulienKaspar) awarded a token.Oct 30 2020, 1:12 PM

Mindinsomnia (mindinsomnia) awarded a token.Nov 2 2020, 7:11 AM

review update

Harbormaster completed remote builds in B11054: Diff 30628.Nov 2 2020, 7:38 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Nov 2 2020, 8:52 PM

Sergey Sharybin (sergey) accepted this revision.Nov 3 2020, 9:16 AM

This revision is now accepted and ready to land.Nov 3 2020, 9:16 AM

This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.

This revision now requires review to proceed.Mar 26 2021, 5:44 PM

This will be committed after merging the dyntopo improvements.

Amal Kumar (amalbubble) awarded a token.Apr 1 2021, 1:06 PM

Vyacheslav (hitrpr) awarded a token.Jun 25 2021, 1:04 PM

Steffen Hartmann (Harti) awarded a token.Jun 25 2021, 6:21 PM

flavien giroud (gritche) awarded a token.Jun 25 2021, 6:50 PM

Amal Kumar (amalbubble) rescinded a token.Jun 25 2021, 7:55 PM

Amal Kumar (amalbubble) awarded a token.

Diogo Valadares Reis dos Santos (DiogoX2) awarded a token.Jul 20 2021, 11:40 PM

Julien Kaspar (JulienKaspar) mentioned this in T98291: Unfinished Revisions.May 20 2022, 6:47 PM