Animation: move group colors switch to user preferences
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Oct 30 2020, 11:01 AM.

Details

Reviewers

Luciano Muñoz Sessarego (looch)
Julian Eisel (Severin)
bassam kurdali (bassamk)
Antonio Vazquez (antoniov)

Group Reviewers

Animation & Rigging

Maniphest Tasks

T82134: Allow disabling Group Colors in animation editors via preference

Commits

rBad85256e7108: Animation: move group colors switch to user preferences

Summary

Move the "Show Group Colors" toggle from a per-editor option to a single user preference in the Animation preferences.

The old "Show Group Colors" toggle had to be set per editor, and was on by default. This meant that disabling group colors would require an action for every file, for every editor.

The Grease Pencil interface warns about this:

(the warning is not part of the below test builds though)

Test builds

Versioning Warning

Note that Blender's sub-version (a hidden number that's used for managing versioning code between various commits of a single release) hasn't been bumped yet in this commit. This means that the code that sets the default to ON of this new user preference is run every time Blender loads the user preferences. Expect the user preference to act like it wasn't saved -- it /is/ saved, it's just that the saved value is overwritten every time it's loaded. This will be resolved when the patch is committed, as only then I can reliably bump the sub-version.

Diff Detail

Repository

rB Blender

Branch

temp-T82134-anim-group-colors-to-prefs

Build Status

Buildable 11051
Build 11051: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Oct 30 2020, 11:01 AM

Sybren A. Stüvel (sybren) created this revision.

Harbormaster completed remote builds in B10997: Diff 30532.Oct 30 2020, 11:01 AM

Sybren A. Stüvel (sybren) added a task: T82134: Allow disabling Group Colors in animation editors via preference.Oct 30 2020, 11:02 AM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Oct 30 2020, 11:05 AM

Sybren A. Stüvel (sybren) added a reviewer: Animation & Rigging.

Sybren A. Stüvel (sybren) added projects: BF Blender (2.92), Animation & Rigging.

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Oct 30 2020, 11:08 AM

Luciano Muñoz Sessarego (looch) awarded a token.Oct 30 2020, 12:09 PM

This is exactly it.
Excellent.

This revision is now accepted and ready to land.Oct 30 2020, 12:13 PM

Juan Gabriel (Juangra_Membata) awarded a token.Oct 30 2020, 12:18 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Oct 30 2020, 12:23 PM

Not tested, but I think we need this too:

diff --git a/release/scripts/startup/bl_ui/properties_grease_pencil_common.py b/release/scripts/startup/bl_ui/properties_grease_pencil_common.py
index 97e87f5451c..9c30227701c 100644
--- a/release/scripts/startup/bl_ui/properties_grease_pencil_common.py
+++ b/release/scripts/startup/bl_ui/properties_grease_pencil_common.py
@@ -881,6 +881,7 @@ class GreasePencilLayerDisplayPanel:
         gpl = gpd.layers.active

         col = layout.row(align=True)
+        col.enabled = context.preferences.edit.use_anim_channel_group_colors
         col.prop(gpl, "channel_color")

         col = layout.row(align=True)

Merge remote-tracking branch 'origin/master' into temp-T82134-anim-group-colors-to-prefs
Update Grease Pencil anim channel side panel to show a warning when channel colors are disabled.

Harbormaster completed remote builds in B11051: Diff 30624.Nov 2 2020, 5:23 PM

Robert Windefjord (Robonnet) awarded a token.Nov 2 2020, 5:24 PM

Sybren A. Stüvel (sybren) mentioned this in T82134: Allow disabling Group Colors in animation editors via preference.Nov 2 2020, 5:25 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) awarded a token.Nov 2 2020, 5:34 PM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Nov 3 2020, 7:52 AM

Antonio Vazquez (antoniov) accepted this revision.Nov 3 2020, 10:51 AM

Closed by commit rBad85256e7108: Animation: move group colors switch to user preferences (authored by Sybren A. Stüvel (sybren)). · Explain WhyNov 9 2020, 11:16 AM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBad85256e7108: Animation: move group colors switch to user preferences.