Page MenuHome

Fix T81673: Color picker picks up UI and Overlay
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Nov 2 2020, 8:45 AM.

Details

Summary

There are two implementations of the Sample Color operation. One is used
by the paint texture and one by the image editor. The image editor
variant sampled from the ibuf directly, but the paint texture variant
was sampling from the screen front buffer. This can lead into incorrect
samples due to color pipeline.

This patch will use the image editor variant when sampling a color for
2d texture painting

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Nov 2 2020, 8:46 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Cleaned up comments and variabled

Sounds good, will assign T81673 to you then @Jeroen Bakker (jbakker)
(edit: ah, you already claimed)

This revision is now accepted and ready to land.Nov 11 2020, 11:04 PM