Differential D9409

Annotation: Set as visible when use it
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Nov 2 2020, 9:12 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Group Reviewers

User Interface

Maniphest Tasks

T82273: Annotations are not enabled by default in Compositor

Commits

rBabc5e7d59600: Annotations: Set as visible when use the annotation tool

Summary

If the annotation draw operator is used, enable the annotations in the current area.

This solves the problem of T82273, T79578 and T80294

Diff Detail

Repository

rB Blender

Branch

R292-temp-annotation (branched from master)

Build Status

Buildable 11041
Build 11041: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Nov 2 2020, 9:12 AM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B11041: Diff 30609.Nov 2 2020, 9:12 AM

Antonio Vazquez (antoniov) added a task: T82273: Annotations are not enabled by default in Compositor.Nov 2 2020, 9:13 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added a reviewer: User Interface.

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Hans Goudey (HooglyBoogly) added a project: User Interface.Nov 3 2020, 6:12 PM

Antonio Vazquez (antoniov) mentioned this in D9401: Annotations: Enable by default in Node Editor.Nov 3 2020, 6:56 PM

This makes sense, and I don't this it's confusing if drawing with the tool enables annotations. It would be expected actually.

This revision is now accepted and ready to land.Nov 4 2020, 3:52 PM

Closed by commit rBabc5e7d59600: Annotations: Set as visible when use the annotation tool (authored by Antonio Vazquez (antoniov)). · Explain WhyNov 4 2020, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBabc5e7d59600: Annotations: Set as visible when use the annotation tool.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gpencil/

annotate_paint.c

38 lines

Diff 30609

View Options

source/blender/editors/gpencil/annotate_paint.c

Annotation: Set as visible when use itClosedPublicActions