Page MenuHome

Fix T82120: Arc miter bevel creates miters on straight edges
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Nov 2 2020, 10:24 PM.

Details

Summary

In some situations where two beveled edges were very close to in-line
but not quite straight, bevel would build a miter where it shouldn't.
The code that chose whether to use a miter at each vertex was slightly
incorrect.

For outer miters there is a check for 3 or more selected edges, but the
inner miters can still be useful with only two beveled edges at a vertex,
so we can't use that check here. Instead I changed the check for in-line
edges to run before determining whether the angle is reflex or not. This
makes the logic a bit more straightforward as well.

The only other place this edges_angle_kind function was used is for
profile=1.0 vertex meshes. I tested and made sure that still works well.

Fixes T82120

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 2 2020, 10:24 PM
Hans Goudey (HooglyBoogly) created this revision.

This looks good to me.

This revision is now accepted and ready to land.Nov 3 2020, 1:35 AM