Page MenuHome

Fix T81799: Enable use self in trimming tool booleans
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Nov 2 2020, 11:08 PM.

Details

Summary

This enables self intersections in the sculpt trimming tools boolean operations.
This should fix wrong booleans results after using the operator to add new disconnected
geometry with the join mode.

Diff Detail

Repository
rB Blender
Branch
T81799 (branched from master)
Build Status
Buildable 11062
Build 11062: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Nov 2 2020, 11:08 PM
Pablo Dobarro (pablodp606) created this revision.

What are the downsides? Is it much slower now, uses more memory?

With self==true, it will be slower because the overlaps discovered by the bvh vs bvh tree test will now discover all the faces that are adjacent to each other (and some more in the neighborhood too. But the tests that happen there are in floating point, not the expensive exact arithmetic ones, so it shouldn't SO much slower. There should not be a significantly large memory impact.

For correctness, this is the right thing to do, and I support it.

Almost sounds like the option should not even be there then. But that's another story.

This revision is now accepted and ready to land.Nov 3 2020, 2:21 PM