Fix T81915: Draw Face Sets not working with deformed sculpt mesh
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Nov 2 2020, 11:16 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T81915: FaceSets drawing not working on mesh with shapekeys

Commits

rB02677ec4e0fa: Fix T81915: Draw Face Sets not working with deformed sculpt mesh

Summary

The draw face sets brush uses the poly center when used in meshes to increase
its precision when working in low poly geometry. For this to work with deformed
meshes, the deformed coordinates from the PBVH should be used instead.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Nov 2 2020, 11:16 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B11063: Diff 30639.Nov 2 2020, 11:22 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Nov 3 2020, 12:28 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) requested changes to this revision.Nov 3 2020, 9:29 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/sculpt_paint/sculpt_face_set.c
144–152	I do not see a reason for this access happening in the loop from the performance reasons. It also feels like such check-and-access happens in other places of sculpt code, so worth looking into making it a reusable function accessing deformed mverts.

This revision now requires changes to proceed.Nov 3 2020, 9:29 AM

Review update

Harbormaster completed remote builds in B11092: Diff 30692.Nov 4 2020, 12:18 AM

Sergey Sharybin (sergey) requested changes to this revision.Nov 4 2020, 9:20 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/sculpt_paint/sculpt.c
295	I would call it `SCULPT_mesh_deformed_mverts_get` with a comment that if there are no shapekeys or modifiers the original mesh vertices array is returned, otherwise PBHV's vertices are returned.

This revision now requires changes to proceed.Nov 4 2020, 9:20 AM