Differential D9425

Property Search: Fix warning
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 2 2020, 11:40 PM.

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

User Interface

Maniphest Tasks

T82341: Property Search: Warning in terminal

Commits

rBcc0b8cb3599f: Fix T82341: Warning in terminal during property search

Summary

After recent changes to the context panel layout (rB187cc5e26d28b1a8),
there has been an error printed in the terminal when running propery search:

Error: separator_spacer() not supported in popups.

The layout code thinks it's drawing in a menu because region->visible
isn't properly set for the other tab searches. This patch sets that field
for the temporary searching region, but it also disables searching in the
context breadcrumbs panel, because at best this will just give results
for the names of the active object, etc. This wasn't helpful since
those labels are mostly in every tab anyway.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 2 2020, 11:40 PM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Nov 2 2020, 11:41 PM

Hans Goudey (HooglyBoogly) added a reviewer: User Interface.

Hans Goudey (HooglyBoogly) added a project: User Interface.

Harbormaster completed remote builds in B11064: Diff 30640.Nov 2 2020, 11:42 PM

Hans Goudey (HooglyBoogly) mentioned this in T82341: Property Search: Warning in terminal.Nov 2 2020, 11:45 PM

Hans Goudey (HooglyBoogly) added a task: T82341: Property Search: Warning in terminal.Nov 3 2020, 12:51 AM

A nicer way to tell a panel to be ignored during search would be using a panel-type flag. We can add that later if useful though, this explicit check is acceptable. Just mention the panel-type flag idea in the comment please.

This revision is now accepted and ready to land.Nov 17 2020, 1:23 PM

Closed by commit rBcc0b8cb3599f: Fix T82341: Warning in terminal during property search (authored by Hans Goudey (HooglyBoogly)). · Explain WhyNov 17 2020, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBcc0b8cb3599f: Fix T82341: Warning in terminal during property search.