Page MenuHome
Differential D9436

macOS: search for Jack framework in system directories
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Nov 3 2020, 3:32 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T79261: Jack Audio not detected under High Sierra
Commits
rB8f2ebcf93f98: macOS: find Jack framework in system directories
Summary

Until it is decided whether to ship JACK with pre-compiled libraries,
search in system directories.

Ref T79261

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Nov 3 2020, 3:32 PM
Ankit Meel (ankitm) created this revision.
Ankit Meel (ankitm) added a reviewer: Brecht Van Lommel (brecht).Nov 3 2020, 3:37 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 3 2020, 3:43 PM
This revision is now accepted and ready to land.Nov 3 2020, 3:43 PM
Ankit Meel (ankitm) added a comment.Nov 3 2020, 3:50 PM

Should this go in 2.91 also ? it is a bug fix after the rB83124856d05e: Cmake/macOS: strictly disallow searching in frameworks commit.

Brecht Van Lommel (brecht) added a comment.Nov 3 2020, 4:27 PM

Yes, it should go into 2.91 then.

Closed by commit rB8f2ebcf93f98: macOS: find Jack framework in system directories (authored by Ankit Meel (ankitm)). · Explain WhyNov 3 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rB8f2ebcf93f98: macOS: find Jack framework in system directories.

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
22 lines

Diff 30665

View Options

build_files/cmake/platform/platform_apple.cmake

Loading...