Cleanup: split sequencer.c file
AbandonedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 3 2020, 3:40 PM.

Details

Reviewers

Summary

Move functions closely related to rendering images and proxies into
render.c and proxy.c files. render.h and proxy.h are created for
functions used internally.

There should be no functional changes.

Diff Detail

Repository

rB Blender

Branch

split-render (branched from master)

Build Status

Buildable 11077
Build 11077: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 3 2020, 3:40 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B11077: Diff 30666.Nov 3 2020, 3:41 PM

Rename intern functions - this doesn't introduce more noise

Harbormaster completed remote builds in B11081: Diff 30670.Nov 3 2020, 4:56 PM

Richard Antalik (ISS) mentioned this in D9439: Rename extern rendering and proxy functions.Nov 3 2020, 5:14 PM

There is a big disconnect between the size of the patch and amount of description given.
What is the summary of changes? Is it about splitting .c files up?

Some related links:

Surely, the links are more about features, but a lot of points is applicable for refactor as well. Basically it should be clear what to expect from the description.

source/blender/sequencer/intern/modifier.c
87	What is a real mask? Mask ID?

Peter Fog (tintwotin) added projects: Video Sequencer, VFX & Video.Nov 4 2020, 9:35 AM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Nov 4 2020, 11:48 AM

@Sergey Sharybin (sergey) I guess I should not really even say "Refactor functions" because individual functions are not changed really.

I forgot to ask question about copyright in licensing block. I have copied this block from sequencer.c, but I am not sure if I can or should change it.
In .c files there are lines that read

* The Original Code is Copyright (C) 2001-2002 by NaN Holding BV.
* All rights reserved.
*
* - Blender Foundation, 2003-2009
* - Peter Schlaile <peter [at] schlaile [dot] de> 2005/2006

Richard Antalik (ISS) retitled this revision from Refactor sequencer rendering and proxy functions to Cleanup: split sequencer.c file.Nov 4 2020, 11:57 AM

Ugh, tricky.

Had a quick discussion with Ton. When splitting files keep the same copyright in all of them.
When adding new code, you can either extend BF copyright (which is preferable) or add your name.

If the change is limited splitting files and it compiles I don't think there is much to review really. Those files are to be split, and reviewing such changes is not adding a lot of value I think.

P.S. One thing for the future, it would also nice to split the header. For example, instead of having /* render.c */ section in SEQ_sequencer.h we would have SEQ_render.h. Just to be clear: is better to do such split as a followup, no need to cram everything into one single change.