Page MenuHome

Fix T82364: Widget anim state not updated when deleting channel in Graph Editor
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Nov 3 2020, 4:52 PM.

Details

Summary

So a keyframed e.g. location slider would stay yellow/green even if its
corresponding channel was removed.

Needs a appropriate notifier so the listeners (e.g.
buttons_area_listener, view3d_buttons_region_listener) would cause a
redraw.

Diff Detail

Repository
rB Blender
Branch
T82364 (branched from master)
Build Status
Buildable 11080
Build 11080: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 3 2020, 4:52 PM
Philipp Oeser (lichtwerk) created this revision.

Is there is a particular reason to add another notifier instead of listening for the existing notification in the relevant places?
I guess maybe the existing notification would cause a lot of unnecessary redraws in those places?

Is there is a particular reason to add another notifier instead of listening for the existing notification in the relevant places?
I guess maybe the existing notification would cause a lot of unnecessary redraws in those places?

ND_ANIMCHAN | NA_EDITED is also fired for channel hiding for example, so no redraw necessary in this case, I guess ND_KEYFRAME | NA_REMOVED describes it better?

This revision is now accepted and ready to land.Nov 5 2020, 4:39 PM