Details

Reviewers

Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)

Maniphest Tasks

T82377: GPencil: New autojoin strokes

Commits

rBe9607f45d85d: GPencil: Automerge last drawn stroke with previous strokes

Summary

This option joins any stroke with an end near the actual stroke. Now it is not limited to the last stroke, any stroke in the same layer for the actual frame can be joined. The join can join two strokes drawing a third stroke.

If the end and the start of the result stroke are very small, the stroke is changed to be cyclic automatically.

There is a limit distance to join the stroke, if the distance is greater than this value, the strokes are not joined. Actually, a constant, threshold distance is used, but we could expose as a parameter in the UI.

The tool can be used with freehand drawing (Note: UI in the videos is outdated, but the functionality is the same) :

or Primitives:

Diff Detail

Repository

rB Blender

Branch

R292-temp-autojoin

Build Status

Buildable 11083
Build 11083: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Nov 3 2020, 5:57 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B11083: Diff 30673.Nov 3 2020, 5:57 PM

Antonio Vazquez (antoniov) retitled this revision from GPencil: First part of the new join by distance to GPencil: Autojoin last stroke.Nov 3 2020, 5:59 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Antonio Vazquez (antoniov) added subscribers: Samuel Bernou (Pullup), Pablo Vazquez (pablovazquez).

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Nov 3 2020, 6:02 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Nov 3 2020, 6:05 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added a task: T82377: GPencil: New autojoin strokes.Nov 3 2020, 6:11 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Nov 3 2020, 6:14 PM

Vyacheslav (hitrpr) awarded a token.Nov 6 2020, 7:58 PM

jorge (jorsh) awarded a token.Nov 6 2020, 9:50 PM

Redesign Join logic

Harbormaster completed remote builds in B11174: Diff 30864.Nov 7 2020, 4:19 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Nov 7 2020, 4:22 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Nov 7 2020, 4:26 PM

Set as cyclic for single stroke

Harbormaster completed remote builds in B11178: Diff 30872.Nov 8 2020, 2:06 PM

Merge branch 'master' into R292-temp-autojoin
Fix crash with single points
Fix trim for join

Harbormaster completed remote builds in B11202: Diff 30931.Nov 10 2020, 10:47 AM

Join several strokes at time

Harbormaster completed remote builds in B11209: Diff 30940.Nov 10 2020, 3:31 PM

Antonio Vazquez (antoniov) retitled this revision from GPencil: Autojoin last stroke to GPencil: Autojoin with previous strokes.Nov 11 2020, 4:39 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Matias Mendiola (mendio) accepted this revision.Nov 11 2020, 4:39 PM

This revision is now accepted and ready to land.Nov 11 2020, 4:39 PM

After the merge of the GSoC Bezier editing project, a lot of the internal code has changed, so this patch has been to be redo it. The funtionality is the same, but need a full test again.

Harbormaster completed remote builds in B11266: Diff 31071.Nov 14 2020, 11:54 AM

@Matias Mendiola (mendio) @Daniel Martinez Lara (pepeland) @Falk David (filedescriptor) Could you retest this patch? After the merge of the Bezier GSoC, a lot of changes were done in the code and I had to redo a lot of things, so it's better to test again to be sure nothing crash. Also, we need to test if the Bezier editing is working fine also.

Fix typo in vector size

Harbormaster completed remote builds in B11267: Diff 31072.Nov 14 2020, 12:14 PM

Fix crash in corner case using a point as join

Harbormaster completed remote builds in B11268: Diff 31073.Nov 14 2020, 12:35 PM

Fix typo in vector size
Fix crash in corner case using a point as join
Keep thickness of the strokes when join them
Fix problem with first stroke and reduce autoclose distance

Harbormaster completed remote builds in B11286: Diff 31127.Nov 16 2020, 3:46 PM

Antonio Vazquez (antoniov) retitled this revision from GPencil: Autojoin with previous strokes to GPencil: Automerge last drawn stroke with previous strokes.Nov 16 2020, 3:47 PM

Closed by commit rBe9607f45d85d: GPencil: Automerge last drawn stroke with previous strokes (authored by Antonio Vazquez (antoniov)). · Explain WhyNov 18 2020, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBe9607f45d85d: GPencil: Automerge last drawn stroke with previous strokes.

Lopo Isaac (lopoIsaac) awarded a token.Nov 24 2020, 3:18 PM

GPencil: Automerge last drawn stroke with previous strokes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 30673

release/scripts/startup/bl_ui/space_view3d_toolbar.py

source/blender/blenkernel/BKE_gpencil_geom.h

source/blender/blenkernel/intern/gpencil_geom.c

source/blender/editors/gpencil/annotate_paint.c

source/blender/editors/gpencil/gpencil_convert.c

source/blender/editors/gpencil/gpencil_edit.c

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_merge.c

source/blender/editors/gpencil/gpencil_paint.c

source/blender/editors/gpencil/gpencil_primitive.c

source/blender/makesdna/DNA_brush_types.h

source/blender/makesrna/intern/rna_brush.c

GPencil: Automerge last drawn stroke with previous strokesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30673

release/scripts/startup/bl_ui/space_view3d_toolbar.py

source/blender/blenkernel/BKE_gpencil_geom.h

source/blender/blenkernel/intern/gpencil_geom.c

source/blender/editors/gpencil/annotate_paint.c

source/blender/editors/gpencil/gpencil_convert.c

source/blender/editors/gpencil/gpencil_edit.c

source/blender/editors/gpencil/gpencil_intern.h

source/blender/editors/gpencil/gpencil_merge.c

source/blender/editors/gpencil/gpencil_paint.c

source/blender/editors/gpencil/gpencil_primitive.c

source/blender/makesdna/DNA_brush_types.h

source/blender/makesrna/intern/rna_brush.c

GPencil: Automerge last drawn stroke with previous strokes
ClosedPublic
Actions

Revision Contents
Changeset List