Page MenuHome
Differential D9452

Fix T82220 Missing viewport update after manual "HDRI Preview Size" input
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Nov 4 2020, 4:11 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Maniphest Tasks
T82220: Missing viewport update after manual "HDRI Preview Size" input
Commits
rB998ae295493f: Fix T82220 Missing viewport update after manual "HDRI Preview Size" input
Summary

This is caused by the TAA being reset after the init phase, leading to
1 sample being kept as valid when it is clearly not.




To fix this, we run the lookdev validation before TAA init.
Diff Detail
Repository 
rB Blender 
Event Timeline
Clément Foucault (fclem) requested review of this revision.Nov 4 2020, 4:11 PM
Clément Foucault (fclem) created this revision.
Clément Foucault (fclem) added a task: T82220: Missing viewport update after manual "HDRI Preview Size" input.
Clément Foucault (fclem) mentioned this in D9382: UI: Adaptive HDRI preview resolution.Nov 4 2020, 5:14 PM
Jeroen Bakker (jbakker) accepted this revision.Nov 6 2020, 8:38 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/draw/engines/eevee/eevee_effects.c


91
here = before the call to EEVEE_temporal_sampling_init ?
This revision is now accepted and ready to land.Nov 6 2020, 8:38 AM
Clément Foucault (fclem) added inline comments.Nov 6 2020, 4:36 PM
source/blender/draw/engines/eevee/eevee_effects.c


91
Yes I'll fix the comment.
Closed by commit rB998ae295493f: Fix T82220 Missing viewport update after manual "HDRI Preview Size" input (authored by Clément Foucault (fclem)).  ·  Explain WhyNov 6 2020, 4:44 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rB998ae295493f: Fix T82220 Missing viewport update after manual "HDRI Preview Size" input.
Ivan Perevala (ivpe) awarded a token.Nov 7 2020, 11:27 AM
Revision Contents
Changeset List
PathSize
source/
blender/
draw/
engines/
eevee/
4 lines
36 lines
1 line
Diff 30725
View Options
source/blender/draw/engines/eevee/eevee_effects.c
Loading...
View Options
source/blender/draw/engines/eevee/eevee_lookdev.c
Loading...
View Options
source/blender/draw/engines/eevee/eevee_private.h
Loading...