These have been replaced with generic functions.
There was one case of the old function still being used. I updated to the new function, no user changes are to be expected.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
These have been replaced with generic functions.
In this patch? Previously, and the deleted functions were no longer in use? What's the context here?
Comment Actions
The functions removed have been replaced with BLI_gNoise and BLI_gTurbulence. This was mostly done previously with the exception of the fcurve noise modifier. This patch changes the noise modifier to use the newer function. The deleted functions are no longer used after the fmodifier change.
Comment Actions
If we accept changing the result of the f-curve modifier (which will change existing animations), this patch seems OK.
Comment Actions
Using the orgBlenderNoise noise basis should result in the same animations. I did a quick test at least.
Comment Actions
This patch still needs a proper description. According to @Campbell Barton (campbellbarton), it will produce different results. According to the patch description it won't. It should be 100% clear from the patch description what happens, and this should have been tested well (not just "should result in the same animation" based on a quick test). If this changes any animation, it will cause much more headaches than just having some single-use functions.