Paths

Table of Contentst

Addons: Check if active object's data is None before calling .keys() on it
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Nov 4 2020, 7:28 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brendon Murphy (meta-androcto)

Maniphest Tasks

T82405: Unable to add extra objects if an empty is selected

Commits

rBA69751991311a: Fix T82405: Check if active object's data is None

Summary

This patch is a fix for T82405. The issue was caused by using context.active_object.data.keys() which doesn't check if data is None. This is the case if the active object is an empty.

Diff Detail

Repository

rBA Blender Add-ons

Branch

2020-11-04-empty-data

Build Status

Buildable 11118
Build 11118: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) requested review of this revision.Nov 4 2020, 7:28 PM

Robert Guetzkow (rjg) created this revision.

Harbormaster completed remote builds in B11118: Diff 30737.Nov 4 2020, 7:28 PM

Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Nov 4 2020, 7:30 PM

Robert Guetzkow (rjg) added a task: T82405: Unable to add extra objects if an empty is selected.

I missed some files with the same issue and will update the diff shortly.

Add required check to more affected Python scripts

Harbormaster completed remote builds in B11119: Diff 30739.Nov 4 2020, 7:48 PM

Missing additional checks

Harbormaster completed remote builds in B11120: Diff 30740.Nov 4 2020, 7:52 PM

Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Nov 4 2020, 8:06 PM

Campbell Barton (campbellbarton) accepted this revision.Nov 6 2020, 11:31 AM

This revision is now accepted and ready to land.Nov 6 2020, 11:31 AM

Closed by commit rBA69751991311a: Fix T82405: Check if active object's data is None (authored by Robert Guetzkow (rjg)). · Explain WhyNov 6 2020, 11:56 AM

This revision was automatically updated to reflect the committed changes.

Robert Guetzkow (rjg) added a commit: rBA69751991311a: Fix T82405: Check if active object's data is None.

Revision Contents
Changeset List

Path

Size

add_mesh_BoltFactory/

Boltfactory.py

3 lines

add_mesh_extra_objects/

Wallfactory.py

3 lines

add_mesh_honeycomb.py

3 lines

add_mesh_pipe_joint.py

3 lines

add_mesh_pyramid.py

3 lines

add_mesh_round_brilliant.py

3 lines

add_mesh_round_cube.py

3 lines

add_mesh_star.py

3 lines

add_mesh_supertoroid.py

3 lines

add_mesh_torusknot.py

3 lines

add_mesh_twisted_torus.py

3 lines

add_mesh_geodesic_domes/

third_domes_panel_271.py

3 lines

Diff 30737

View Options

add_mesh_BoltFactory/Boltfactory.py

View Options

add_mesh_extra_objects/Wallfactory.py

View Options

add_mesh_extra_objects/add_mesh_honeycomb.py

View Options

add_mesh_extra_objects/add_mesh_pipe_joint.py

View Options

add_mesh_extra_objects/add_mesh_pyramid.py

View Options

add_mesh_extra_objects/add_mesh_round_brilliant.py

View Options

add_mesh_extra_objects/add_mesh_round_cube.py

View Options

add_mesh_extra_objects/add_mesh_star.py

View Options

add_mesh_extra_objects/add_mesh_supertoroid.py

View Options

add_mesh_extra_objects/add_mesh_torusknot.py

View Options

add_mesh_extra_objects/add_mesh_twisted_torus.py

View Options

add_mesh_geodesic_domes/third_domes_panel_271.py

Addons: Check if active object's data is None before calling .keys() on itClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30737

add_mesh_BoltFactory/Boltfactory.py

add_mesh_extra_objects/Wallfactory.py

add_mesh_extra_objects/add_mesh_honeycomb.py

add_mesh_extra_objects/add_mesh_pipe_joint.py

add_mesh_extra_objects/add_mesh_pyramid.py

add_mesh_extra_objects/add_mesh_round_brilliant.py

add_mesh_extra_objects/add_mesh_round_cube.py

add_mesh_extra_objects/add_mesh_star.py

add_mesh_extra_objects/add_mesh_supertoroid.py

add_mesh_extra_objects/add_mesh_torusknot.py

add_mesh_extra_objects/add_mesh_twisted_torus.py

add_mesh_geodesic_domes/third_domes_panel_271.py

Addons: Check if active object's data is None before calling .keys() on it
ClosedPublic
Actions

Revision Contents
Changeset List