SCULPT_flush_update_done tags all necessary viewports to update and it
was not used after restoring the coordinates from sculpt undo.
Details
Details
- Reviewers
Sergey Sharybin (sergey) Campbell Barton (campbellbarton) Bastien Montagne (mont29) - Maniphest Tasks
- T82409: Sculpted models in Solid or Wireframe viewports do not update in other Material or Rendered viewports when changes are undone (Undo). This can cause a desync that the artist may not notice until it's too late.
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T82409 (branched from master)
- Build Status
Buildable 11122 Build 11122: arc lint + arc unit
Event Timeline
Comment Actions
It is not clear to me why sculpt mode requires special logic to tag viewports, but other types of undo does not. To me it seems the problem is either deeper and needs more generic solution for undo types, or the sculpt undo doesn't do something properly.
There is also seems to be duplication in tagging/updating happening in SCULPT_flush_update_done and in few lines below the call.