To be removed? see comment below.

Do not really see the point to have intermediate vars here, would just do:

	i = txt_get_span(text->lines.first, text->curl);
	st->text_cursor_pos[0] = (text->curc - st->left) * st->cwidth;
	st->text_cursor_pos[1] = sa->winy - ((i - st->top) * st->lheight);

… and remove the debug print in final version too, we do not want that on by default even in debug build. ;)

sa is no more available here in master (since 10/11), ar->winy maybe?

tsst… needless blank lines. :P

maybe precise comment? runtime, and in pixels (if I have understood patch correctly ;) ).

See comment below (and needless blank lines again).

This is not what you want to do I think, you want to make this prop read-only, right? Defining a getter func and setting setter to NULL will not make the prop read-only!

You do not need the getter at all here, and should rather define the prop as readonly (i.e. replace RNA_def_property_int_funcs by RNA_def_property_clear_flag(prop, PROP_EDITABLE);).

Add in 'tip' a reference about the unit (pixel)? And no need to define an update for this prop, if it's read-only…

Grrrrr… xD

this is a reasonably expensive function.

Calling it each time on the offchange someone might want to access text_cursor_pos is unnecessary.

Suggest to make this a function rather then a property. then the function can do any checks it needs to at the time its run.

just finding the first text space is really arbitrary, its even possible st and ar are unrelated.

See how text_scroll_to_cursor__area gets the region from the ScrArea