Differential D9472

Fix off-by-one error when creating bitmap for lasso gesture
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 5 2020, 4:10 PM.

Details

Reviewers

Pablo Dobarro (pablodp606)

Maniphest Tasks

T82043: Sculpting lasso Mask artefacts

Commits

rB29693c7b070a: Sculpt: Fix off-by-one error when creating bitmap for lasso gesture

Summary

This might also fix T82043 (I got an ASAN crash instead).

The computed bounding box of the lasso is inclusive.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 5 2020, 4:10 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B11141: Diff 30774.Nov 5 2020, 4:10 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 5 2020, 4:11 PM

Jacques Lucke (JacquesLucke) added a task: T82043: Sculpting lasso Mask artefacts.

cleanup

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 5 2020, 4:13 PM

Jacques Lucke (JacquesLucke) added a reviewer: Pablo Dobarro (pablodp606).

Harbormaster completed remote builds in B11142: Diff 30775.Nov 5 2020, 4:13 PM

Pablo Dobarro (pablodp606) accepted this revision.Nov 5 2020, 11:43 PM

This revision is now accepted and ready to land.Nov 5 2020, 11:43 PM

Closed by commit rB29693c7b070a: Sculpt: Fix off-by-one error when creating bitmap for lasso gesture (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 9 2020, 11:49 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB29693c7b070a: Sculpt: Fix off-by-one error when creating bitmap for lasso gesture.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_mask.c

8 lines

Diff 30885

View Options

source/blender/editors/sculpt_paint/paint_mask.c

Fix off-by-one error when creating bitmap for lasso gestureClosedPublicActions