source/blender/editors/animation/keyframes_general.c
461–462	This should probably be rewritten to use the `FCurveSegment` struct from D13531
source/blender/editors/space_graph/graph_slider_ops.c
945–949	Call `BLI_freelistN(&segments);` to avoid memory leak

This revision now requires changes to proceed.Dec 13 2021, 4:16 PM

Christoph Lendenfeld (ChrisLend) mentioned this in D9374: Blend To Neighbour Implementation.Dec 15 2021, 11:24 PM

Erick Tukuniata (erickblender) awarded a token.Dec 16 2021, 12:20 AM

Update to latest master
use new function slider_factor_get_and_remember
fix memory leak
use FCurveSegment as parameter for ease_fcurve_segment

Christoph Lendenfeld (ChrisLend) marked 2 inline comments as done.Feb 22 2022, 9:53 AM

Gavriel Lavi (Gavriel5578) awarded a token.Mar 20 2022, 3:03 PM

@Sybren A. Stüvel (sybren)
Why aren't the changes been reviewed? I'm kind a new to programming (want to understend how it works).

I like it, just a few nitpicks from me. :)

source/blender/editors/animation/keyframes_general.c
482	The parentheses on the right-hand side of the statement are redundant.
source/blender/editors/space_graph/graph_slider_ops.c
816	I think `LISTBASE_FOREACH` can be used here.

rebase onto master and implement requested changes

Christoph Lendenfeld (ChrisLend) marked 2 inline comments as done.Nov 24 2022, 10:22 AM

In D9479#389991, @Dave Love (DaveLove) wrote:

@Sybren A. Stüvel (sybren)
Why aren't the changes been reviewed? I'm kind a new to programming (want to understend how it works).

No special reason, just many things to do in little time. Now that I have more time to spend on Animation & Rigging, I hope to catch up with all the reviews eventually :)

The code looks good to me!

Just one thing I'm wondering, UI/UX-wise. Right now the operator starts at 50%, which results in a straight line, and 0% and 100% are the two extremes (ignoring "E for overshoot"). Would it make sense to use the range -100% to 100%, and have 0% as the straight line? That way also the overshooting values are more symmetrical; currently -100% would be the inverse of 200%, and with my proposal those would be -150% and +150%.

Sybren A. Stüvel (sybren) removed a reviewer: Wayde Moss (GuiltyGhost).Dec 16 2022, 12:35 PM

In D9479#457262, @Sybren A. Stüvel (sybren) wrote:

The code looks good to me!

Just one thing I'm wondering, UI/UX-wise. Right now the operator starts at 50%, which results in a straight line, and 0% and 100% are the two extremes (ignoring "E for overshoot"). Would it make sense to use the range -100% to 100%, and have 0% as the straight line? That way also the overshooting values are more symmetrical; currently -100% would be the inverse of 200%, and with my proposal those would be -150% and +150%.

In order to change that I'd need to change the slider to have a settable min and max. That's a good idea to do anyway, but I think it's a bit much for this patch.

I agree!

This revision is now accepted and ready to land.Dec 22 2022, 4:50 PM

Closed by commit rB76a68649c1c1: Animation: Graph Editor Ease operator (authored by Christoph Lendenfeld (ChrisLend)). · Explain WhyJan 5 2023, 10:11 AM

This revision was automatically updated to reflect the committed changes.

Christoph Lendenfeld (ChrisLend) added a commit: rB76a68649c1c1: Animation: Graph Editor Ease operator.

Ease Implementation
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45964

source/blender/editors/animation/keyframes_general.c

source/blender/editors/include/ED_keyframes_edit.h

source/blender/editors/space_graph/graph_intern.h

source/blender/editors/space_graph/graph_ops.c

source/blender/editors/space_graph/graph_slider_ops.c

Ease ImplementationClosedPublicActions