Page MenuHome
Differential D9501

Cleanup: Clang-tidy modernize-use-default-member-init
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Nov 7 2020, 5:18 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB7054d0370125: Cleanup: Clang-tidy modernize-use-default-member-init
Summary

Using assignment syntax as we don't use {} initialization yet.

Diff Detail

Repository
rB Blender
Branch
modernize (branched from master)
Build Status
Buildable 12647
Build 12647: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Nov 7 2020, 5:18 PM
Ankit Meel (ankitm) created this revision.
Ankit Meel (ankitm) mentioned this in T78535: Code quality day: Clang-Tidy.Nov 7 2020, 5:24 PM
Ankit Meel (ankitm) added inline comments.Nov 9 2020, 7:03 AM
source/blender/blenlib/intern/mesh_intersect.cc
1028

note to self. This one should be explicit.

Ankit Meel (ankitm) updated this revision to Diff 33592.Feb 5 2021, 1:09 PM
Harbormaster completed remote builds in B12647: Diff 33592.Feb 5 2021, 1:09 PM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Feb 5 2021, 2:11 PM
Ankit Meel (ankitm) added a reviewer: Sergey Sharybin (sergey).
Ankit Meel (ankitm) updated this revision to Diff 33598.Feb 5 2021, 2:14 PM
  • restore warning as error
Harbormaster completed remote builds in B12653: Diff 33598.Feb 5 2021, 2:14 PM
Sergey Sharybin (sergey) requested changes to this revision.Feb 5 2021, 2:29 PM
Sergey Sharybin (sergey) added inline comments.
source/blender/blenlib/intern/mesh_intersect.cc
1063–1064

The syntax is ITT_value() = default;.

This revision now requires changes to proceed.Feb 5 2021, 2:29 PM
Ankit Meel (ankitm) updated this revision to Diff 33601.Feb 5 2021, 2:35 PM
  • verify that it builds
Harbormaster completed remote builds in B12655: Diff 33601.Feb 5 2021, 2:36 PM
Sergey Sharybin (sergey) accepted this revision.Feb 5 2021, 2:38 PM
This revision is now accepted and ready to land.Feb 5 2021, 2:38 PM
Closed by commit rB7054d0370125: Cleanup: Clang-tidy modernize-use-default-member-init (authored by Ankit Meel (ankitm)). · Explain WhyFeb 5 2021, 2:41 PM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rB7054d0370125: Cleanup: Clang-tidy modernize-use-default-member-init.

Revision Contents
Changeset List

PathSize
5 lines
source/
blender/
blenlib/
intern/
19 lines

Diff 33592

View Options

.clang-tidy

Loading...
View Options

source/blender/blenlib/intern/mesh_intersect.cc

Loading...