Page MenuHome

UI: "About Blender" with full logo
ClosedPublic

Authored by Yevgeny Makarov (jenkm) on Nov 8 2020, 10:43 PM.

Details

Summary

UI: "About Blender" with full logo.

Source file:

Screenshots:

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Nov 8 2020, 10:43 PM
Yevgeny Makarov (jenkm) created this revision.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

I do think the layout looks a bit better, nice design here.

source/blender/windowmanager/intern/wm_splash_screen.c
286

I don't see the point of removing these sorts of comments in this patch. I would rather keep them-- it's helpful for someone scanning this function for the first time to see these titles as sections in the code.

Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 13 2020, 5:01 AM
This revision now requires changes to proceed.Nov 13 2020, 5:01 AM

This does look a lot nicer than the current design.

I still have a slight fondness for the current layout, but only because of the way it differs from the Splash dialog while this is closely similar. But that is probably just some bias to wanting to show different uses of the new Alert icons. This does look better though.

There is one thing to check and (possibly) address. Apologies that I can't test this at the moment. Of course if you simply increase the user scale this entire dialog will properly increase in size proportionally in all directions. But I am hoping that you can do a test of keeping it at a normal scale but doubling the size of Preferences / Themes / Text Style / (All) Font points. We have some low vision users who use it this way. You will see an doubling of the dialog width while the height will not double, which is expected behavior. But you might want to change the way the logo is scaled if it forces the dialog to get taller than we want (for this accessibility change). So you might decide to have the logo (only) change by UI scale and not by font size, or you might want to limit the upper bound of the scale increase of the logo. Up to you really. We're just trying to support very large fonts on a regular monitor the best we can.

Yevgeny Makarov (jenkm) updated this revision to Diff 31044.EditedNov 13 2020, 1:17 PM
Yevgeny Makarov (jenkm) marked an inline comment as done.

Added some comments.

I just thought nine times blender_logo is enough to figure out what's going on :)

I think this looks fine with scaled fonts:

I think it's even a good thing that Splash and About are somewhat similar to each other,
and they differ from confirmation dialogs that have a different purpose.

This revision is now accepted and ready to land.Nov 16 2020, 4:19 AM
This revision was automatically updated to reflect the committed changes.