Page MenuHome
Differential D9519

Measureit using uniform to send line width info
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Nov 10 2020, 4:58 AM.

Details

Reviewers
Jeroen Bakker (jbakker)
Group Reviewers
EEVEE & Viewport
Maniphest Tasks
T82562: Measureit line width inoperative
Summary

This patch allows measureit to behave correctly with line thickness option.

Need to be used together with D9518: Adding 3D_POLYLINE_UNIFORM_COLOR to PyGPU shader API.

Diff Detail

Event Timeline

YimingWu (NicksBest) requested review of this revision.Nov 10 2020, 4:58 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) added a task: T82562: Measureit line width inoperative.
Jeroen Bakker (jbakker) requested changes to this revision.Nov 11 2020, 3:37 PM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).

Some minor changes. I didn't actually test it yet will do that after the patch is updated.

measureit/measureit_geometry.py
46

Code style. Python functions are all lowercase with underscores between the words.
Perhaps use get/set_imm_line_width so it is easier to understand what it is doing and keep the style the same.

This revision now requires changes to proceed.Nov 11 2020, 3:37 PM
YimingWu (NicksBest) updated this revision to Diff 30992.Nov 12 2020, 3:24 AM

use imm_set_line_width.

(This was originally meant to be "look similar" to bgl.glLineWidth() but this way it indeed looks beter :D )

Jeroen Bakker (jbakker) accepted this revision as: Jeroen Bakker (jbakker).Nov 16 2020, 1:14 PM
Jeroen Bakker (jbakker) accepted this revision.
This revision is now accepted and ready to land.Nov 16 2020, 1:14 PM
Campbell Barton (campbellbarton) mentioned this in rBA41658df313e1: Fix T82562: Measureit line drawing doesn't work.Jan 27 2021, 11:23 AM
Campbell Barton (campbellbarton) closed this revision.EditedJan 27 2021, 11:27 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

I tried applying this patch but ran into issues which have probably been introduced since this patch was written.

Committed rBA41658df313e1: Fix T82562: Measureit line drawing doesn't work, closing.

Revision Contents
Changeset List

PathSize
measureit/
18 lines

Diff 30926

View Options

measureit/measureit_geometry.py

Loading...