Page MenuHome
Differential D9529

GPencil: Remove ID from operators to fix T82597
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Nov 11 2020, 12:18 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Maniphest Tasks
T82597: Crash running with --debug-wm and pressing F3
Commits
rBe9b955b99cd3: GPencil: Remove ID from operators to fix T82597
Summary

Instead to use the ID of the object, now the parameter is an Enum with Selected object or New.

If use selected mode, the first grease pencil object selected is used. If none of the selected objects is a grease pencil object, a new object is created.

Diff Detail

Repository
rB Blender
Branch
R292-fix-trace (branched from master)
Build Status
Buildable 11216
Build 11216: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Nov 11 2020, 12:18 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B11216: Diff 30959.Nov 11 2020, 12:18 PM
Antonio Vazquez (antoniov) added reviewers: Campbell Barton (campbellbarton), Bastien Montagne (mont29).Nov 11 2020, 12:19 PM
Antonio Vazquez (antoniov) added a project: Grease Pencil.
Antonio Vazquez (antoniov) updated this revision to Diff 30960.Nov 11 2020, 12:20 PM

Cleanup commit included by error

Harbormaster completed remote builds in B11217: Diff 30960.Nov 11 2020, 12:21 PM
Campbell Barton (campbellbarton) added a comment.Nov 12 2020, 3:13 AM

Generally fine, some details noted inline.

source/blender/editors/gpencil/gpencil_utils.c
3027–3040

This could be made into a generic function, that takes the object type as an argument.

3030

Prefer ob_found or ob_result.

Campbell Barton (campbellbarton) added inline comments.Nov 12 2020, 3:23 AM
source/blender/editors/gpencil/gpencil_mesh.c
229–231

There aren't any checks for the object data being editable (library data for example). This can be handled in a separate patch though.

Antonio Vazquez (antoniov) updated this revision to Diff 31005.Nov 12 2020, 4:27 PM
  • Move the get selected object to shared module.
  • Rename variables.
Harbormaster completed remote builds in B11240: Diff 31005.Nov 12 2020, 4:29 PM
Campbell Barton (campbellbarton) accepted this revision.Nov 13 2020, 10:46 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/blenkernel/intern/layer_utils.c
195 ↗(On Diff #31005)

bytype is not used anywhere by_type is, eg: UI_panel_find_by_type

This revision is now accepted and ready to land.Nov 13 2020, 10:46 AM
Closed by commit rBe9b955b99cd3: GPencil: Remove ID from operators to fix T82597 (authored by Antonio Vazquez (antoniov)). · Explain WhyNov 13 2020, 3:21 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rBe9b955b99cd3: GPencil: Remove ID from operators to fix T82597.
Antonio Vazquez (antoniov) mentioned this in D9554: GPencil: Include only_editable flag to selected_by_type API.Nov 13 2020, 5:32 PM
Hans Goudey (HooglyBoogly) added a task: T82597: Crash running with --debug-wm and pressing F3.May 30 2022, 4:06 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
gpencil/
2 lines
editors/
gpencil/
35 lines
34 lines
15 lines
include/
7 lines

Diff 30959

View Options

source/blender/draw/engines/gpencil/gpencil_cache_utils.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_mesh.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_trace_ops.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_utils.c

Loading...
View Options

source/blender/editors/include/ED_gpencil.h

Loading...