Page MenuHome
Differential D9536

Resolve an assumption on the internal structure of std:string on arm64
Needs ReviewPublic
Actions

Authored by Developer Ecosystem Engineering (Developer-Ecosystem-Engineering) on Nov 11 2020, 10:37 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

An assumption about the internal structure of std:string was causing corruption on many scenes in arm64.
Visible in Classroom, Pavillion, Cosmos

This was upstreamed in the latest OpenImageIO and will not be necessary when a newer version is integrated.

Diff Detail

Repository
rB Blender

Event Timeline

Developer Ecosystem Engineering (Developer-Ecosystem-Engineering) requested review of this revision.Nov 11 2020, 10:37 PM
Developer Ecosystem Engineering (Developer-Ecosystem-Engineering) created this revision.
Tzachi Zidenberg (tsahee) added a subscriber: Tzachi Zidenberg (tsahee).EditedNov 12 2020, 10:30 AM

a) could you point me to where this patch is taken from? I don't see it in github https://github.com/OpenImageIO/oiio/blob/master/src/libutil/ustring.cpp
b) why test for arm64 and not aarch64 ? (this is probably a question for the upstream patch, but I can't find it)

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
patches/
31 lines

Diff 30988

View Options

build_files/build_environment/patches/openimageio.diff

Loading...