Page MenuHome

Sculpt: Move cloth solver collisions to the sculpt settings
Needs RevisionPublic

Authored by Pablo Dobarro (pablodp606) on Nov 12 2020, 6:10 PM.

Details

Summary

This moves the property of brushes and filter operator to enable
collisions in the sculpt cloth solver to the sculpt settings. This way,
the same property is shared between all uses of the solver (brushes,
filters and deformation targets). This makes sense as this is a prefernce
of the solver, not something that defines the behaviour of a tool.

After this patch I'll start adding more solver options (iterations,
deformation constraints strength...) to the same place in the UI, that
will also affect all tools that use the solver.

Diff Detail

Repository
rB Blender
Branch
sculpt-cloth-tool-collisions-settings (branched from master)
Build Status
Buildable 11243
Build 11243: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Nov 12 2020, 6:10 PM
Pablo Dobarro (pablodp606) created this revision.
Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Move cloth solver collisions to the scultp settings to Sculpt: Move cloth solver collisions to the sculpt settings.Nov 12 2020, 6:10 PM
Sergey Sharybin (sergey) requested changes to this revision.Nov 13 2020, 10:17 AM

Other than versioning, moving settings around is probably fine.

After this patch I'll start adding more solver options (iterations, deformation constraints strength...) to the same place in the UI

Is there a design/roadmap? Is adding extra settings really makes things better for artists, or is it creating even-more-difficult-to-manage brush system? Is it something what should really be done instead of the Brush Management?

I want to see a bigger picture plan, design, roadmap.

This revision now requires changes to proceed.Nov 13 2020, 10:17 AM

This is part of T77634
Moving the solver options here simplifies the brush and tools settings for brush management as you won't need presets for brushes with collisions and without collisions anymore.

Replied in T77634. To me it doesn't really seem to be a design/roadmap task, but more of a set of various TODOs/ideas.