Remove workaround for drawing the rotation gizmo ('ED_gizmo_types_dial_3d_draw_util')
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Nov 12 2020, 6:43 PM.

Details

Reviewers

Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Commits

rBea182deeb9cd: Remove workaround for drawing the rotation gizmo

Summary

Since {648350e456490f8d6258e7de9bf94d3a6a34dbb2}, transform gizmos are no longer hidden during transform.

The same can be observed for rotation gizmos.

However, as a workaround for these rotation gizmos, there was already a drawing utility running.

With the gizmo and the utility this drawing is now being done twice.

So remove the utility/workaround and update the gizmo accordingly.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 11244
Build 11244: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Nov 12 2020, 6:43 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B11244: Diff 31010.Nov 12 2020, 6:43 PM

Rebase on master

Harbormaster completed remote builds in B22441: Diff 52320.Jun 7 2022, 5:05 AM

Germano Cavalcante (mano-wii) retitled this revision from Transform: Remove the "wm.h" header to Remove workaround for drawing the rotation gizmo (`ED gizmo types dial_3d_draw_util`).Jun 7 2022, 5:12 AM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)

Germano Cavalcante (mano-wii) added a reviewer: Campbell Barton (campbellbarton).

Germano Cavalcante (mano-wii) retitled this revision from Remove workaround for drawing the rotation gizmo (`ED gizmo types dial_3d_draw_util`) to Remove workaround for drawing the rotation gizmo ('ED_gizmo_types_dial_3d_draw_util').Jun 7 2022, 5:20 AM

Accepting with some minor requests.