Fix T76699: Support macOS inbetween mouse/tablet.
ClosedPublic
Actions

Authored by Nicholas Rishel (nicholas_rishel) on Nov 15 2020, 9:36 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB96200110eb0f: Fix T76699: Support macOS inbetween mouse/tablet.

Summary

Coalescing on macOS overwrites a singular unprocessed mouse event. To
receive all mouse and tablet events coalescing is disabled.

Disabling coalescing for macOS disables coalescing for trackpad
gestures. Repeat trackpad events are unnecessary and found to
negatively impact performance thus are re-coalesced in Window Manager.

Diff Detail

Repository: rB Blender

Event Timeline

Nicholas Rishel (nicholas_rishel) requested review of this revision.Nov 15 2020, 9:36 PM

Nicholas Rishel (nicholas_rishel) created this revision.

Harbormaster completed remote builds in B11273: Diff 31095.Nov 15 2020, 9:36 PM

Nicholas Rishel (nicholas_rishel) added a reviewer: Brecht Van Lommel (brecht).Nov 15 2020, 9:38 PM

@Brecht Van Lommel (brecht) Most of this diff comes from your template. Only notable fix is wm_event_free_last was modified to pop the WM event queue tail instead of the head.

I posted this as a diff in case you wanted to rope in other module owners for review given it modifies input behavior; if you think that's unnecessary I can squash and push to master.

Yevgeny Makarov (jenkm) added a subscriber: Yevgeny Makarov (jenkm).Nov 15 2020, 10:30 PM

Brecht Van Lommel (brecht) accepted this revision.Nov 16 2020, 12:34 PM

This revision is now accepted and ready to land.Nov 16 2020, 12:34 PM

No need to involve more reviewers.

Yevgeny Makarov (jenkm) mentioned this in T59836: Touch on Gizmos can return invalid cursor coordinates.Nov 16 2020, 1:46 PM

Rebase master

Harbormaster completed remote builds in B11290: Diff 31134.Nov 16 2020, 9:37 PM

Closed by commit rB96200110eb0f: Fix T76699: Support macOS inbetween mouse/tablet. (authored by Nicholas Rishel (nicholas_rishel)). · Explain WhyNov 16 2020, 9:49 PM

This revision was automatically updated to reflect the committed changes.

Nicholas Rishel (nicholas_rishel) added a commit: rB96200110eb0f: Fix T76699: Support macOS inbetween mouse/tablet..