Page MenuHome
Differential D9576

Fix crash in BLI_gzopen when file cannot be opened
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Nov 16 2020, 1:07 PM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Richard Antalik (ISS)
Maniphest Tasks
T81271: Fluid: Crash with empty cache path
Commits
rB8b815c7ce565: Fix T81271: Fix crash in BLI_gzopen on Windows
Summary

This patch fixes T81271. Previously the return value of ufopen wasn't checked and if it failed, NULL was passed into fclose() which resulted in a crash. This patch avoids this by returning from BLI_gzopen when the file cannot be created.

Diff Detail

Repository
rB Blender
Branch
2020-11-16-gzip (branched from master)
Build Status
Buildable 11279
Build 11279: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) requested review of this revision.Nov 16 2020, 1:07 PM
Robert Guetzkow (rjg) created this revision.
Harbormaster completed remote builds in B11279: Diff 31118.Nov 16 2020, 1:07 PM
Sebastián Barschkis (sebbas) accepted this revision.Nov 16 2020, 1:09 PM
This revision is now accepted and ready to land.Nov 16 2020, 1:09 PM
Closed by commit rB8b815c7ce565: Fix T81271: Fix crash in BLI_gzopen on Windows (authored by Robert Guetzkow (rjg)). · Explain WhyNov 16 2020, 1:22 PM
This revision was automatically updated to reflect the committed changes.
Robert Guetzkow (rjg) added a commit: rB8b815c7ce565: Fix T81271: Fix crash in BLI_gzopen on Windows.
Raimund Klink (Raimund58) awarded a token.Dec 14 2020, 11:49 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
intern/
7 lines

Diff 31118

View Options

source/blender/blenlib/intern/fileops.c

Loading...