Add Custom Falloff Curve to the Vertex Weight Proximity Modifier
ClosedPublic
Actions

Authored by Christian Friedrich (rbx775) on Nov 18 2020, 4:27 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Howard Trickey (howardt)

Commits

Summary

The Vertex Weight Edit Modifier already got the Custom Curve so it could be added here too.

Comment cleanup.

source/blender/modifiers/intern/MOD_weightvgproximity.c
259–311	Any rational for that change?

This revision now requires changes to proceed.Nov 20 2020, 12:52 PM

Thank you Bastien,

honest answer: no. :)
I think I was copying VertexWeightEdit Modifier too closely.

Should be better now.

Thanks, LGTM now

This revision is now accepted and ready to land.Nov 20 2020, 4:57 PM

Notes: While actually testing the patch before committing realized there were still tow issues with it:

An assert about proximity modifier not using the 'custom curve' falloff was left in the code, should have been removed.
Versioning code was missing, to add the cmap curve to existing Proximity modifier upon reading (otherwise existing files would just crash).

Remember to always use debug builds when developing, and to always also check with existing .blend files. ;)

This revision was automatically updated to reflect the committed changes.