Details

Reviewers

Luciano Muñoz Sessarego (looch)
bassam kurdali (bassamk)
Hjalti Hjálmarsson (hjalti)
Pablo Fournier (pablico)

Group Reviewers

Animation & Rigging

Commits

rBe4ca1fc4ea43: Animation: New Euler filter implementation

Summary

This new discontinuity filter performs actions on the entire Euler rotation, rather than on the individual X/Y/Z channels only. This should make it fix a wider range of discontinuities, for example those in T52744: Euler Filter doesn't work.

This first review pass is to get feedback from animators on the functionality, so ignore the code for now.

Test builds:

Diff Detail

Repository

rB Blender

Branch

temp-T52744-euler-filter

Build Status

Buildable 11370
Build 11370: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Nov 19 2020, 12:58 PM

Sybren A. Stüvel (sybren) created this revision.

Harbormaster completed remote builds in B11338: Diff 31207.Nov 19 2020, 12:59 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Nov 19 2020, 1:07 PM

Sybren A. Stüvel (sybren) added a reviewer: Animation & Rigging.

Sybren A. Stüvel (sybren) added projects: BF Blender, Animation & Rigging.

Cleanup: Animation, fix uninitialised variable in Euler filter code
Merge remote-tracking branch 'origin/master' into temp-T52744-euler-filter

Harbormaster completed remote builds in B11339: Diff 31208.Nov 19 2020, 1:08 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Nov 19 2020, 1:23 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Nov 19 2020, 1:30 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Nov 19 2020, 7:31 PM

Daniel Salazar (zanqdo) added a subscriber: Daniel Salazar (zanqdo).Nov 20 2020, 3:06 AM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Nov 20 2020, 7:33 AM

Reintroduce single-channel filter for completeness.
Better reporting after the filter is done, to prevent scary error messages
Add check on keyframe X-coordinates

Harbormaster completed remote builds in B11361: Diff 31244.Nov 20 2020, 2:08 PM

Fix compiler warning

Harbormaster completed remote builds in B11362: Diff 31245.Nov 20 2020, 2:14 PM

Juan Gabriel (Juangra_Membata) awarded a token.Nov 20 2020, 2:20 PM

Christoph Lendenfeld (ChrisLend) awarded a token.Nov 20 2020, 2:37 PM

Add unit tests

Harbormaster completed remote builds in B11366: Diff 31249.Nov 20 2020, 3:22 PM

Implement Euler filter by using matrices instead of quaternions

Harbormaster completed remote builds in B11368: Diff 31252.Nov 20 2020, 3:41 PM

Update comments and variable naming

Harbormaster completed remote builds in B11369: Diff 31254.Nov 20 2020, 3:59 PM

Add unit test for BKE_fcurve_keyframe_move_value_with_handles

Harbormaster completed remote builds in B11370: Diff 31255.Nov 20 2020, 4:10 PM

Bataev Artem (shader) awarded a token.Nov 20 2020, 4:37 PM

I've updated the test builds for the latest changes. The most visible change is the way the operator reports its result; it's less "error message" and more "this is what I've done".

Andrea Monzini (Andrea_Monzini) awarded a token.Nov 20 2020, 5:59 PM

lucas veber (lucky3) awarded a token.Nov 20 2020, 6:14 PM

Fin O'Riordan (fin.eskimo) awarded a token.Nov 22 2020, 8:56 AM

Fin O'Riordan (fin.eskimo) added a subscriber: Fin O'Riordan (fin.eskimo).

Looks like a huge improvement from my tests : (gifs below)
old filter: <click to play>

new filter: <click to play>

test file:

euler_test.blend26 MBDownload

Thanks

thanks for testing fin!, results are great.

Luciano Muñoz Sessarego (looch) added a comment.Nov 23 2020, 10:05 AM

This comment was removed by Luciano Muñoz Sessarego (looch).

Okay it's working nicely,

I wonder if euler filter should: work on all curves when no keyframe is selected
and if some keyframes are selected: work just on those: meaning you can create an area to be evaluated and corrected if for obvious reasons you don't want to touch the entire curve?

This patch doesn't change the selection of what to run the filter on. It only changes the filter itself, making it more useful. I think it's a good idea to keep those separated.

Luciano Muñoz Sessarego (looch) accepted this revision.Nov 23 2020, 12:21 PM

This revision is now accepted and ready to land.Nov 23 2020, 12:21 PM

Closed by commit rBe4ca1fc4ea43: Animation: New Euler filter implementation (authored by Sybren A. Stüvel (sybren)). · Explain WhyNov 23 2020, 1:36 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBe4ca1fc4ea43: Animation: New Euler filter implementation.

New Euler filter implementation
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31255

source/blender/blenkernel/BKE_fcurve.h

source/blender/blenkernel/intern/fcurve.c

source/blender/blenkernel/intern/fcurve_test.cc

source/blender/editors/space_graph/graph_edit.c

tests/python/bl_animation_fcurves.py

New Euler filter implementationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31255

source/blender/blenkernel/BKE_fcurve.h

source/blender/blenkernel/intern/fcurve.c

source/blender/blenkernel/intern/fcurve_test.cc

source/blender/editors/space_graph/graph_edit.c

tests/python/bl_animation_fcurves.py

New Euler filter implementation
ClosedPublic
Actions

Revision Contents
Changeset List