Paths

Table of Contentst

Differential D9604

Fix wrong use of 'U.pixelsize'
Needs ReviewPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Nov 19 2020, 1:56 PM.

Tags

Subscribers

Brecht Van Lommel (brecht)

Harley Acheson (harley)

Details

Reviewers

None

Group Reviewers

Summary

Fix for wrong use of U.pixelsize.

The "Line Width" (U.pixelsize) should not affect:

tooltip width
submenu arrow icon width
dynamic-topology detail size
zoom operator delta
compositor backdrop manipulator size
mini axis size
navigate icon offset from mini axis
gradient size (preview the active side of the line gestures)
cursor position value (from other windows)

Diff Detail

Repository: rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Nov 19 2020, 1:56 PM

Yevgeny Makarov (jenkm) created this revision.

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Nov 19 2020, 2:12 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/blenkernel/intern/scene.c
2927 ↗	(On Diff #31214)	Don't change this one.

Yevgeny Makarov (jenkm) updated this revision to Diff 31216.Nov 19 2020, 2:19 PM

Yevgeny Makarov (jenkm) marked an inline comment as done.

Yevgeny Makarov (jenkm) planned changes to this revision.Jan 2 2021, 9:59 PM

Yevgeny Makarov (jenkm) updated this revision to Diff 43430.Oct 16 2021, 11:16 PM

Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

I can only spot one thing that might need double-checking. node_composit_backdrop_viewer looks to be drawing a diagonal cross shape using GPU_PRIM_LINES, so if you increase line-width (separately from scale) you might need to increase the cross size to keep proportions and avoid making one that is too fat and short.

I don't quite understand the purpose of this cross, but changing (depending on Line Width) its size twice definitely looks wrong. rB29a7ad8b1a76

Btw, there are many more places that need to be rechecked, I excluded them from this patch for simplicity:
snap distance, select dist, gizmo hotspot, etc. Of course, they can vary depending on the Line Width, but not twice as much.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gizmo_library/

gizmo_types/

2 lines

interface/

interface_draw.c

4 lines

interface_icons_event.c

2 lines

interface_region_popup.c

2 lines

interface_region_tooltip.c

6 lines

interface_widgets.c

10 lines

screen/

4 lines

sculpt_paint/

paint_image_proj.c

4 lines

6 lines

2 lines

space_action/

2 lines

space_clip/

2 lines

space_graph/

2 lines

space_image/

2 lines

space_node/

2 lines

space_sequencer/

sequencer_draw.c

9 lines

space_view3d/

2 lines

view3d_gizmo_navigate.c

2 lines

view3d_gizmo_ruler.c

6 lines

view3d_project.c

2 lines

view3d_select.c

4 lines

2 lines

windowmanager/

gizmo/

intern/

4 lines

intern/

2 lines

8 lines

Diff 31216

source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c

Loading...

source/blender/editors/interface/interface_draw.c

Loading...

source/blender/editors/interface/interface_icons_event.c

Loading...

source/blender/editors/interface/interface_region_popup.c

Loading...

source/blender/editors/interface/interface_region_tooltip.c

Loading...

source/blender/editors/interface/interface_widgets.c

Loading...

source/blender/editors/screen/screen_ops.c

Loading...

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...

source/blender/editors/sculpt_paint/paint_ops.c

Loading...

source/blender/editors/sculpt_paint/sculpt.c

Loading...

source/blender/editors/space_action/action_draw.c

Loading...

source/blender/editors/space_clip/clip_ops.c

Loading...

source/blender/editors/space_graph/graph_select.c

Loading...

source/blender/editors/space_image/image_ops.c

Loading...

source/blender/editors/space_node/drawnode.c

Loading...

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...

source/blender/editors/space_view3d/view3d_draw.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_navigate.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_ruler.c

Loading...

source/blender/editors/space_view3d/view3d_project.c

Loading...

source/blender/editors/space_view3d/view3d_select.c

Loading...

source/blender/editors/space_view3d/view3d_utils.c

Loading...

source/blender/windowmanager/gizmo/intern/wm_gizmo_map.c

Loading...

source/blender/windowmanager/intern/wm_gesture.c

Loading...

source/blender/windowmanager/intern/wm_window.c

Loading...