This creates a new persistent base if it does not exists when a new
stroke starts. This way, the "Use persistent" option of cloth and layer
brushes will work by default without expeting the user to store a
persistent base manually. Users will still store a persistent base at
any point by using the operator.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- ensure-persistent-base (branched from master)
- Build Status
Buildable 11386 Build 11386: arc lint + arc unit
Event Timeline
Comment Actions
Great improvement! It feels like this patch really frees up my mind when sculpting cloth (no more "did I remember to press persistent base).
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 7740 | It seems it was possible to store persistent base in any mode before, so why is the BMESH case ignored? | |
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 7740 | See D9728. | |
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 7740 | To me this change is more something like: implicitly press "store persistent base" button if it was not pressed prior to the stroke start. If the dynamic topology does not work correct with persistent base, it should be explicitly disabled with clear communication to the artist. This will include generating an unsupported warning in the "store persistent base" operator. Having different behavior when the state was stored explicitly and implicitly is not something I find a correct thing to do. Also, all the non-trivial logic explanation should happen as a comment in the code. | |