Page MenuHome
Differential D9624

CMake/macOS: Replace -Xlinker flag with -Wl.
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Nov 21 2020, 8:59 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Platform: macOS
Commits
rB36426b0a6856: CMake/macOS: Replace -Xlinker with -Wl.
Summary

Causes link issues on Xcode-12 where the "New Build System"
is the default.
https://devtalk.blender.org/t/input-file-cannot-be-found-xlinker/16273

Another fix is to set build system to legacy using -T buildsystem=1 flag
in CMake. But it needs CMake 3.19. See CMAKE_XCODE_BUILD_SYSTEM.

Diff Detail

Repository
rB Blender
Branch
linker (branched from master)
Build Status
Buildable 11382
Build 11382: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Nov 21 2020, 8:59 PM
Ankit Meel (ankitm) created this revision.
Harbormaster completed remote builds in B11382: Diff 31276.Nov 21 2020, 8:59 PM
Ankit Meel (ankitm) added a comment.Nov 21 2020, 9:02 PM

Another usage is in findpythonunixlibs cmake module. But that's not used for macOS. Hope that's fine.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Nov 21 2020, 9:03 PM
Ankit Meel (ankitm) added a reviewer: Platform: macOS.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Nov 22 2020, 10:48 AM
Matt Hill (theothermatt) added a subscriber: Matt Hill (theothermatt).Nov 22 2020, 4:14 PM

This patch appears to do the trick, with it applied I can build in Xcode using the "new build system".

Brecht Van Lommel (brecht) accepted this revision.Nov 23 2020, 11:18 AM
This revision is now accepted and ready to land.Nov 23 2020, 11:18 AM
Closed by commit rB36426b0a6856: CMake/macOS: Replace -Xlinker with -Wl. (authored by Ankit Meel (ankitm)). · Explain WhyNov 23 2020, 12:06 PM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rB36426b0a6856: CMake/macOS: Replace -Xlinker with -Wl..

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
6 lines

Diff 31276

View Options

build_files/cmake/platform/platform_apple.cmake

Loading...