Paths

Table of Contentst

Differential D9627

Cleanup: Rename curve struct fields
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 22 2020, 6:42 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rB218360a89217: Cleanup: Rename curve struct fields

Summary

These existing names were unhelpful at best, actively confusing at worst.
This patch renames them to be consistent with the terms used to refer
to the values in the UI.
width -> offset
ext1 -> extrude
ext2 -> bevel_radius

Diff Detail

Repository

rB Blender

Branch

dna-curve-rename (branched from master)

Build Status

Buildable 11385
Build 11385: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 22 2020, 6:42 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B11385: Diff 31286.Nov 22 2020, 6:42 PM

Hans Goudey (HooglyBoogly) added a project: Modeling.Nov 22 2020, 6:42 PM

Campbell Barton (campbellbarton) accepted this revision.Apr 1 2021, 1:49 PM

This revision is now accepted and ready to land.Apr 1 2021, 1:49 PM

Evan Wilson (EAW) awarded a token.Apr 5 2021, 2:36 AM

Closed by commit rB218360a89217: Cleanup: Rename curve struct fields (authored by Hans Goudey (HooglyBoogly)). · Explain WhyDec 2 2021, 4:01 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB218360a89217: Cleanup: Rename curve struct fields.

Duarte Farrajota Ramos (duarteframos) awarded a token.Dec 2 2021, 12:14 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_curve.h

4 lines

intern/

curve_bevel.c

44 lines

displist.c

6 lines

blenloader/

intern/

versioning_260.c

2 lines

draw/

engines/

overlay/

overlay_edit_text.c

3 lines

intern/

draw_cache.c

4 lines

editors/

curve/

editcurve_paint.c

4 lines

gpencil/

gpencil_convert.c

2 lines

makesdna/

DNA_curve_defaults.h

2 lines

DNA_curve_types.h

2 lines

intern/

dna_rename_defs.h

3 lines

makesrna/

intern/

rna_curve.c

10 lines

Diff 31286

View Options

source/blender/blenkernel/BKE_curve.h

View Options

source/blender/blenkernel/intern/curve_bevel.c

View Options

source/blender/blenkernel/intern/displist.c

View Options

source/blender/blenloader/intern/versioning_260.c

View Options

source/blender/draw/engines/overlay/overlay_edit_text.c

View Options

source/blender/draw/intern/draw_cache.c

View Options

source/blender/editors/curve/editcurve_paint.c

View Options

source/blender/editors/gpencil/gpencil_convert.c

View Options

source/blender/makesdna/DNA_curve_defaults.h

View Options

source/blender/makesdna/DNA_curve_types.h

View Options

source/blender/makesdna/intern/dna_rename_defs.h

View Options

source/blender/makesrna/intern/rna_curve.c

Cleanup: Rename curve struct fieldsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31286

source/blender/blenkernel/BKE_curve.h

source/blender/blenkernel/intern/curve_bevel.c

source/blender/blenkernel/intern/displist.c

source/blender/blenloader/intern/versioning_260.c

source/blender/draw/engines/overlay/overlay_edit_text.c

source/blender/draw/intern/draw_cache.c

source/blender/editors/curve/editcurve_paint.c

source/blender/editors/gpencil/gpencil_convert.c

source/blender/makesdna/DNA_curve_defaults.h

source/blender/makesdna/DNA_curve_types.h

source/blender/makesdna/intern/dna_rename_defs.h

source/blender/makesrna/intern/rna_curve.c

Cleanup: Rename curve struct fields
ClosedPublic
Actions

Revision Contents
Changeset List