Page MenuHome
Differential D9636

Fix T82945: Crash when dragging modifiers in Outliner
AbandonedPublic
Actions

Authored by Fabrício Luis (ce3po) on Nov 24 2020, 2:28 AM.

Details

Reviewers
Bastien Montagne (mont29)
Group Reviewers
User Interface
Pipeline, Assets & I/O
Maniphest Tasks
T82945: Crash when dragging modifiers in Outliner
Summary

Problem

Variable psys is null.
Crash when press one Ctrl + z after steps for reproduce error the T82945.

Solution

Avoid null particle system.
Press many Ctrl + z is ok.

Diff Detail

Repository
rB Blender
Branch
fix_T82945 (branched from master)
Build Status
Buildable 11402
Build 11402: arc lint + arc unit

Event Timeline

Fabrício Luis (ce3po) created this revision.Nov 24 2020, 2:28 AM
Harbormaster completed remote builds in B11402: Diff 31317.Nov 24 2020, 2:28 AM
Fabrício Luis (ce3po) requested review of this revision.Nov 24 2020, 2:28 AM
Fabrício Luis (ce3po) edited the summary of this revision. (Show Details)Nov 24 2020, 2:38 AM
Ankit Meel (ankitm) added a task: T82945: Crash when dragging modifiers in Outliner.Dec 4 2020, 5:29 AM
Ankit Meel (ankitm) added a reviewer: User Interface.
Ankit Meel (ankitm) added projects: Nodes & Physics, User Interface.
Hans Goudey (HooglyBoogly) added a reviewer: Pipeline, Assets & I/O.Jan 5 2021, 10:35 PM
Hans Goudey (HooglyBoogly) edited projects, added Pipeline, Assets & I/O; removed Nodes & Physics.
Bastien Montagne (mont29) requested changes to this revision.Jan 6 2021, 5:24 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Don't think this is proper way to fix this, low-level particle code in BKE should typically not have to check for a NULL psys...

Further more, I am not sure whether a NULL psys at that point is expected. or if this is actually a bug. Needs more investigation in undo and particle areas of the code first imho.

This revision now requires changes to proceed.Jan 6 2021, 5:24 PM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Jan 6 2021, 5:53 PM

I haven't looked into this bug specifically, but D9537 may have dealt with a similar case. Maybe it would be useful to look at the code that added for copying modifier particle systems.

Bastien Montagne (mont29) abandoned this revision.Jan 19 2021, 7:05 PM

Fixed as rBbc95c249a765.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
5 lines
editors/
space_outliner/
11 lines

Diff 31317

View Options

source/blender/blenkernel/intern/particle.c

Loading...
View Options

source/blender/editors/space_outliner/outliner_tree.c

Loading...