Fix: Cannot select object by clicking on its instances.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 24 2020, 1:11 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)
Brecht Van Lommel (brecht)

Commits

rBe922dd7d8a30: Viewport: cannot select object by clicking on its instances

Summary

Currently, one cannot select an object by clicking on its instances, if the object itself is not shown in the viewport (by disabling the "Viewport" option in the Instancing settings).
There was already a comment that states an assumption that is not fullfilled in all cases: This relies on dupli instances being after their instancing object.

The solution is give every object the correct select_id in the depsgraph object iterator right before rendering.

instance_select_test.blend729 KBDownload

The video shows that I cannot select by clicking on the one of the four outer cones.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 24 2020, 1:11 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B11408: Diff 31327.Nov 24 2020, 1:11 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 24 2020, 1:25 PM

use simpler solution

Harbormaster completed remote builds in B11410: Diff 31330.Nov 24 2020, 1:25 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 24 2020, 1:31 PM

Jacques Lucke (JacquesLucke) added reviewers: Jeroen Bakker (jbakker), Clément Foucault (fclem), Brecht Van Lommel (brecht).

Does this works with multiple recursion?

source/blender/draw/engines/overlay/overlay_armature.c
1913	Is this 100% safe? are all edit bones operators flushing updates to evaluated object nowadays? It should be safe but I'm a bit curious to know why this loop was using the original object before.