Page MenuHome
Differential D9643

UI: Standardize "Selected Only" UI in exporters
Needs ReviewPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 25 2020, 4:31 AM.

Details

Reviewers
Nathan Craddock (natecraddock)
Group Reviewers
User Interface
Summary

In preparation for turning this property on by default,
this patch makes its location and labeling consistent
among the default-enabled exporters.

The changes to the addons repo aren't included in this diff,
but the code is trivial anyway, I will just commit that if
this is accepted.

BeforeAfter

Diff Detail

Repository
rB Blender
Branch
export-selected-only-consistent-ui (branched from master)
Build Status
Buildable 11414
Build 11414: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 25 2020, 4:31 AM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B11414: Diff 31354.Nov 25 2020, 4:32 AM
Hans Goudey (HooglyBoogly) added a reviewer: User Interface.Nov 25 2020, 4:33 AM
Hans Goudey (HooglyBoogly) added a project: User Interface.
Pieter Schiettecatte (Schiette) awarded a token.Nov 25 2020, 8:53 PM
Benjamin Sauder (kioku) awarded a token.Nov 26 2020, 12:53 PM
Nathan Craddock (natecraddock) accepted this revision.Nov 27 2020, 6:50 PM
Nathan Craddock (natecraddock) added a subscriber: Nathan Craddock (natecraddock).

It looks like you left the text as "Selection Only" for X3D export based on the screenshot. Otherwise looks good

This revision is now accepted and ready to land.Nov 27 2020, 6:50 PM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): User Interface.Mar 26 2021, 5:40 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.

This revision now requires review to proceed.Mar 26 2021, 5:40 PM
Hans Goudey (HooglyBoogly) mentioned this in D15142: Default "Selected Only" to True When Exporting Objects.Jun 7 2022, 12:34 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
io/
10 lines
13 lines
6 lines

Diff 31354

View Options

source/blender/editors/io/io_alembic.c

Loading...
View Options

source/blender/editors/io/io_collada.c

Loading...
View Options

source/blender/editors/io/io_usd.c

Loading...