Differential D9644

Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and dynamic paint modifiers
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 25 2020, 9:49 AM.

Tags

None

Subscribers

None

Details

Reviewers

Sebastián Barschkis (sebbas)

Maniphest Tasks

T82729: Crash in rna_EffectorWeight_path when object has fluid and dynamic paint modifiers

Commits

rBa08a08cb4c26: Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and dynamic…
rB4b248c16589b: Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and

Summary

Looks like prior to the introduction of mantaflow, the former
SmokeModifierData always had a domain initialized (even if its type was
set to None). Since mataflow, the FluidModifierData type needs to be set
to MOD_FLUID_TYPE_DOMAIN (otherwise domain is invalid)

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 25 2020, 9:49 AM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B11415: Diff 31355.Nov 25 2020, 9:49 AM

Sebastián Barschkis (sebbas) added inline comments.Nov 26 2020, 11:38 AM

source/blender/makesrna/intern/rna_object_force.c
816	Just noticed the outdated comment
820–821	I'd ensure that the domain pointer exists too.

also check for valid domain
correct old comment ('smoke' > 'fluid')

Harbormaster completed remote builds in B11426: Diff 31383.Nov 26 2020, 2:25 PM

Sebastián Barschkis (sebbas) accepted this revision.Nov 26 2020, 2:29 PM

This revision is now accepted and ready to land.Nov 26 2020, 2:29 PM

Closed by commit rB4b248c16589b: Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 26 2020, 5:13 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB4b248c16589b: Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and.

Jeroen Bakker (jbakker) added a commit: rBa08a08cb4c26: Fix T82729: Crash in rna_EffectorWeight_path when object has fluid and dynamic….Dec 2 2020, 8:51 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_object_force.c

5 lines

Diff 31387

source/blender/makesrna/intern/rna_object_force.c

Loading...