Differential D9653

Sculpt: Elastic Transform
AbandonedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Nov 27 2020, 1:38 AM.

Tags

None

Subscribers

Jason (SPYNeox)

Joseph Eagar (joeedh)

Tokens

"Love" token, awarded by gilberto_rodrigues."Burninate" token, awarded by shader.

Details

Reviewers

Sergey Sharybin (sergey)
Daniel Bystedt (dbystedt)
Julien Kaspar (JulienKaspar)
Campbell Barton (campbellbarton)

Summary

This implements transform modes for the transform tool and Elastic
Transform. This mode uses the Kelvinlets from elastic deform to apply
the transformation to the mesh, using the cursor radius to control the
elasticity falloff.

In order for this to work, the transform tool uses incremental mode when
elastic transform is enabled. This allows to integrate the displacement of
the Kelvinet in multiple steps.

Diff Detail

Repository

Branch

elastic-transform (branched from master)

Build Status

Buildable 11431
Build 11431: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Nov 27 2020, 1:38 AM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B11431: Diff 31394.Nov 27 2020, 1:38 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Nov 27 2020, 1:44 AM

fix displacement mode
add comment to kelvinlet parameters

Harbormaster completed remote builds in B11433: Diff 31397.Nov 27 2020, 1:53 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Nov 27 2020, 4:49 AM

Bataev Artem (shader) awarded a token.Dec 1 2020, 2:32 PM

In order for this to work, the transform tool now always works based on delta from the previous position instead of delta from the initial position.

Is this still true? Though "original" transform tool works in "absolute" mode.

From the code side in sculpting seems fine.

The tool interface code seems a bit suspicious to me, and the only person how can help is Campbell ;)

Before committing please make sure Julien and Daniel are happy :)

Is this still true? Though "original" transform tool works in "absolute" mode.

No, I updated the description.

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Dec 2 2020, 12:05 AM

Looks nice!

Daniel Bystedt (dbystedt) mentioned this in D9540: Sculpt: Option to transform only the sculpt pivot.Dec 2 2020, 4:30 PM

This seems fine for me.

Jason (SPYNeox) added a subscriber: Jason (SPYNeox).Feb 24 2022, 7:07 AM

Julien Kaspar (JulienKaspar) mentioned this in T98291: Unfinished Revisions.May 20 2022, 6:47 PM

Joseph Eagar (joeedh) added a reviewer: Joseph Eagar (joeedh).May 27 2022, 10:04 AM

Joseph Eagar (joeedh) removed a reviewer: Joseph Eagar (joeedh).

Joseph Eagar (joeedh) added a subscriber: Joseph Eagar (joeedh).

Joseph Eagar (joeedh) mentioned this in D15041: Sculpt: Elastic Transform (Rebased).May 27 2022, 10:09 AM

This patch has been rebased and replaced by D15041 and is again under review.

*edit* accidentally submitted review here, replied to D15041 instead.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_toolsystem_toolbar.py

9 lines

source/

blender/

editors/

sculpt_paint/

40 lines

sculpt_intern.h

9 lines

sculpt_transform.c

108 lines

makesdna/

DNA_scene_types.h

11 lines

makesrna/

intern/

rna_sculpt_paint.c

20 lines

Diff 31394

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

Loading...

source/blender/editors/sculpt_paint/sculpt.c

Loading...

source/blender/editors/sculpt_paint/sculpt_intern.h

Loading...

source/blender/editors/sculpt_paint/sculpt_transform.c

Loading...

source/blender/makesdna/DNA_scene_types.h

Loading...

source/blender/makesrna/intern/rna_sculpt_paint.c

Loading...