Page MenuHome

NLA: Action Strip Defaults Sync Length On
ClosedPublic

Authored by Wayde Moss (GuiltyGhost) on Nov 28 2020, 11:43 AM.

Details

Summary

See T82309#1055564 T63675: Placing keyframe outside of NLA Strip frame range while in Tweak Mode no longer possible and their duplicates for how Default-off can cause confusion.

This is just for convenience since it allows animators to keyframe outside of the strip's bounds by default. This was likely off by default before since Syncing Length would undesirably shift the whole animation after leaving tweak mode (fixed by D7602: NLA: Fix Sync Length) and the animator wasn't able to keyframe outside the strip bounds anyways (fixed by D7533: NLA: Evaluate Tweak Strip Within Synced Action Bounds). Now it's better if the flag was on by default. While the animator is still roughly developing their animation NLA-wise, they won't have to worry about strip bound keying failures. When they are more certain of the strip bounds, they can disable the flag to prevent affecting the rest of the NLA system.

Diff Detail

Repository
rB Blender

Event Timeline

Wayde Moss (GuiltyGhost) requested review of this revision.Nov 28 2020, 11:43 AM
Wayde Moss (GuiltyGhost) created this revision.
Sybren A. Stüvel (sybren) requested changes to this revision.Nov 30 2020, 1:18 PM

The patch description should be a bit more elaborate, as it'll also serve as (the basis for) the final commit message.

source/blender/blenkernel/intern/nla.c
357–359

Just add this to line 337, so that the flag is only set once.
I think that, when you mention T82309#1055954 in the commit message, the comment isn't necessary. As I look at it, NLASTRIP_FLAG_SYNC_LENGTH should have always been added, but since the "sync length" feature didn't work properly (until you fixed it!), this couldn't be done.

This revision now requires changes to proceed.Nov 30 2020, 1:18 PM
Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Dec 1 2020, 4:34 AM
Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Dec 1 2020, 4:46 AM
Wayde Moss (GuiltyGhost) marked an inline comment as done.
  • group flag set and remove out of date comment
source/blender/blenkernel/intern/nla.c
336–337

This comment is a bit hard to understand. Since it's no longer relevant anyways, I removed it.

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Dec 1 2020, 5:02 AM

👍 on the comment removal.

This revision is now accepted and ready to land.Dec 3 2020, 12:05 PM