Differential D9670

Fix greasepencil add-on keymap item removal and doc string
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Nov 30 2020, 11:14 AM.

Tags

None

Subscribers

Aaron Carlisle (Blendify)

Tokens

"Like" token, awarded by Pullup.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Samuel Bernou (Pullup)

Maniphest Tasks

T83099: heap-use-after-free in script_load_addons test

Commits

rBA73976fd55a45: Fix T83099: Greasepencil add-on keymap item removal

Summary

This patch fixes T83099. This issue was caused by the greasepencil add-on removing keymap items it hadn't created itself, thus invalidating references that other add-ons held for the keymap items they've created. This is fixed by storing a reference to the created keymap items alongside the keymap and only removing those items that the add-on created itself. Additionally, this commit fixes the doc string that was no longer valid

Diff Detail

Repository

rBA Blender Add-ons

Branch

2020-11-30-keymap-v2

Build Status

Buildable 11450
Build 11450: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) created this revision.Nov 30 2020, 11:14 AM

Harbormaster completed remote builds in B11449: Diff 31435.Nov 30 2020, 11:14 AM

Robert Guetzkow (rjg) requested review of this revision.Nov 30 2020, 11:14 AM

Please keep space cleanup out of revisions, it makes it fairly annoying to review otherwise...

This revision now requires changes to proceed.Nov 30 2020, 11:19 AM

Remove whitespace formatting changes caused by auto-formatting of the IDE

Harbormaster completed remote builds in B11450: Diff 31437.Nov 30 2020, 11:57 AM

Sorry about that, my PyCharm IDE is configured to auto-format for PEP 8 compliance.

Samuel Bernou (Pullup) awarded a token.Nov 30 2020, 12:46 PM

Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Nov 30 2020, 12:48 PM

Bastien Montagne (mont29) accepted this revision.Nov 30 2020, 6:36 PM

This revision is now accepted and ready to land.Nov 30 2020, 6:36 PM

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Nov 30 2020, 6:49 PM

Aaron Carlisle (Blendify) added inline comments.

greasepencil_tools/__init__.py
28	This allows proper doc versioning instead of always using the developmental version.

Robert Guetzkow (rjg) added inline comments.Nov 30 2020, 6:50 PM

greasepencil_tools/__init__.py
28	I'll add this change before committing.

Use doc_url matching the Blender version

Harbormaster completed remote builds in B11473: Diff 31475.Dec 1 2020, 10:17 AM

Robert Guetzkow (rjg) updated this revision to Diff 31476.Dec 1 2020, 10:21 AM

This comment was removed by Robert Guetzkow (rjg).

Harbormaster completed remote builds in B11474: Diff 31476.Dec 1 2020, 10:22 AM

Remove whitespace formatting changes again

Harbormaster completed remote builds in B11475: Diff 31477.Dec 1 2020, 10:25 AM

Bastien Montagne (mont29) accepted this revision.Dec 1 2020, 10:26 AM

Closed by commit rBA73976fd55a45: Fix T83099: Greasepencil add-on keymap item removal (authored by Robert Guetzkow (rjg)). · Explain WhyDec 1 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

Robert Guetzkow (rjg) added a commit: rBA73976fd55a45: Fix T83099: Greasepencil add-on keymap item removal.

Revision Contents
Changeset List

Path

Size

greasepencil_tools/

4 lines

7 lines

13 lines

Diff 31437

greasepencil_tools/init.py

Loading...

greasepencil_tools/box_deform.py

Loading...

greasepencil_tools/prefs.py

Loading...