Page MenuHome
Differential D9677

Compositor: New Exposure Node
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Nov 30 2020, 9:03 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Jeroen Bakker (jbakker)
Commits
rB6538f1e600ad: Compositor: New Exposure Node
Summary

This new node increases the radiance of an image by a scalar value.
Previously, the only way to adjust the the exposure of an image was with
math node or using the scene's color management.

Diff Detail

Repository
rB Blender
Branch
comp_exposure (branched from master)
Build Status
Buildable 11792
Build 11792: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Nov 30 2020, 9:03 PM
Aaron Carlisle (Blendify) created this revision.
Harbormaster completed remote builds in B11458: Diff 31452.Nov 30 2020, 9:03 PM
Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Nov 30 2020, 9:04 PM
Aaron Carlisle (Blendify) added reviewers: Brecht Van Lommel (brecht), Jeroen Bakker (jbakker).
Aaron Carlisle (Blendify) added projects: BF Blender, Compositing.
Aaron Carlisle (Blendify) mentioned this in D6544: Compositor: Exposure Node.
Aaron Carlisle (Blendify) mentioned this in T83253: Compositor: Exposure Node.Nov 30 2020, 9:12 PM
Marco (nacioss) awarded a token.Nov 30 2020, 10:22 PM
Lee JiHong (redorange) added a subscriber: Lee JiHong (redorange).Dec 3 2020, 6:47 AM
Jeroen Bakker (jbakker) added a comment.Dec 16 2020, 2:40 PM

Some small adjustments.

source/blender/compositor/operations/COM_ColorExposureOperation.cpp
47

store pow(2, exposure) in a local variable. It is constant.

source/blender/nodes/composite/nodes/node_composite_exposure.c
17

2020

Jeroen Bakker (jbakker) requested changes to this revision.Dec 16 2020, 2:40 PM
This revision now requires changes to proceed.Dec 16 2020, 2:40 PM
Aaron Carlisle (Blendify) updated this revision to Diff 32094.Dec 17 2020, 3:52 AM
  • Merge branch 'master' into comp_exposure
  • Address review
Harbormaster completed remote builds in B11792: Diff 32094.Dec 17 2020, 3:53 AM
Aaron Carlisle (Blendify) marked 2 inline comments as done.Dec 17 2020, 3:54 AM
Jeroen Bakker (jbakker) accepted this revision.Dec 18 2020, 12:28 PM

LGTM.

This revision is now accepted and ready to land.Dec 18 2020, 12:28 PM
Closed by commit rB6538f1e600ad: Compositor: New Exposure Node (authored by Aaron Carlisle (Blendify)). · Explain WhyDec 19 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.
Aaron Carlisle (Blendify) added a commit: rB6538f1e600ad: Compositor: New Exposure Node.
炎臻 (PrettyFireNOI7) awarded a token.Dec 22 2020, 3:43 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
1 line
source/
blender/
blenkernel/
1 line
intern/
1 line
compositor/
4 lines
intern/
4 lines
nodes/
34 lines
37 lines
operations/
49 lines
57 lines
makesrna/
1 line
nodes/
1 line
1 line
1 line
composite/
nodes/
46 lines

Diff 32094

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/blenkernel/intern/node.c

Loading...
View Options

source/blender/compositor/CMakeLists.txt

Loading...
View Options

source/blender/compositor/intern/COM_Converter.cpp

Loading...
View Options

source/blender/compositor/nodes/COM_ColorExposureNode.h

Loading...
View Options

source/blender/compositor/nodes/COM_ColorExposureNode.cpp

Loading...
View Options

source/blender/compositor/operations/COM_ColorExposureOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_ColorExposureOperation.cpp

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/NOD_composite.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_exposure.c

Loading...