Collada exporter and importer assigning specular, mirror map to incorrect textures/samplers
Needs ReviewPublic
Actions

Authored by Mark McKay (kitfox) on Jan 3 2015, 8:01 PM.

Details

Reviewers

Nathan Letwory (jesterking)
Gaia Clary (gaiaclary)
Sukhitha Jayathilake (phabtar)

Summary

At the moment, the Collada effect exporter does odd things like map the specular map to the diffuse map upon export. I've changed some of the mappings in EffectsExporter::writeTextures() to sort this out. I also made a changes in DocumentImporter::write_profile_COMMON().

Sorry for all the blank lines in the diff. My text editor is set to automatically cut out trailing whitespace.

Diff Detail

Event Timeline

Mark McKay (kitfox) updated this revision to Diff 3091.Jan 3 2015, 8:01 PM

Mark McKay (kitfox) retitled this revision from to Collada exporter and importer assigning specular, mirror map to incorrect textures/samplers.

Mark McKay (kitfox) updated this object.

Mark McKay (kitfox) added reviewers: Gaia Clary (gaiaclary), Nathan Letwory (jesterking), Jeroen Bakker (jbakker), Sukhitha Jayathilake (phabtar).Jan 5 2015, 7:12 PM

Without checking at the functionality, you need to get rid of all non functional whitespace changes. Just make sure your editor does not auto correct them

This should be a lot cleaner.

Jeroen Bakker (jbakker) resigned from this revision.Jan 6 2015, 8:38 PM

Jeroen Bakker (jbakker) removed a reviewer: Jeroen Bakker (jbakker).