NLA Refactor: remove redundant NlaEvalChannel valid mask write
ClosedPublic
Actions

Authored by Wayde Moss (GuiltyGhost) on Dec 1 2020, 11:54 AM.

Details

Reviewers

Alexander Gavrilov (angavrilov)
Sybren A. Stüvel (sybren)
Christoph Lendenfeld (ChrisLend)

Commits

rB10ce2a1016ae: NLA: Redundant NlaEvalChannel Valid Mask Write

Summary

nla cleanup: remove redundant NlaEvalChannel valid mask write. The field will already be properly written to in (anim_sys.c) nla_eval_domain_action(). It's easier to understand the property's usage after removing the redundancy.

No functional changes.
Split from D9247: Refactor: NLA Prep for D8296

Diff Detail

Repository: rB Blender

Event Timeline

Wayde Moss (GuiltyGhost) created this revision.Dec 1 2020, 11:54 AM

Harbormaster completed remote builds in B11477: Diff 31482.Dec 1 2020, 11:54 AM

Wayde Moss (GuiltyGhost) requested review of this revision.Dec 1 2020, 11:54 AM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Dec 1 2020, 11:56 AM

Wayde Moss (GuiltyGhost) added a project: Animation & Rigging.

Wayde Moss (GuiltyGhost) added a reviewer: Sybren A. Stüvel (sybren).Dec 2 2020, 7:42 AM

Nothing to add from my side. nla_eval_domain() indeed does this check already so it seems to be safe to get rid of

This revision is now accepted and ready to land.Dec 13 2020, 12:03 AM

Sybren A. Stüvel (sybren) accepted this revision.Jan 14 2021, 5:05 PM

Closed by commit rB10ce2a1016ae: NLA: Redundant NlaEvalChannel Valid Mask Write (authored by Wayde Moss (GuiltyGhost)). · Explain WhyJan 15 2021, 1:06 AM

This revision was automatically updated to reflect the committed changes.

Wayde Moss (GuiltyGhost) added a commit: rB10ce2a1016ae: NLA: Redundant NlaEvalChannel Valid Mask Write.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

anim_sys.c

8 lines

Diff 32800

View Options

source/blender/blenkernel/intern/anim_sys.c

NLA Refactor: remove redundant NlaEvalChannel valid mask writeClosedPublicActions