Page MenuHome
Differential D9691

Nla Refactor: is_fcurve_evaluatable()
ClosedPublic
Actions

Authored by Wayde Moss (GuiltyGhost) on Dec 1 2020, 12:05 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Christoph Lendenfeld (ChrisLend)
Group Reviewers
Animation & Rigging
Commits
rB32e4ded24b6b: Nla Refactor: is_fcurve_evaluatable()
Summary

Future patches D8867: Feature: NLA Merge Strips and D8296: Feature: NLA: Evaluate Whole NLA Stack in Tweak Mode make use of it.

No functional changes.
Split from D9247: Refactor: NLA Prep for D8296

Diff Detail

Repository
rB Blender
Branch
arcpatch-D9691 (branched from master)
Build Status
Buildable 11847
Build 11847: arc lint + arc unit

Event Timeline

Wayde Moss (GuiltyGhost) requested review of this revision.Dec 1 2020, 12:05 PM
Wayde Moss (GuiltyGhost) created this revision.
Harbormaster completed remote builds in B11479: Diff 31484.Dec 1 2020, 12:06 PM
Wayde Moss (GuiltyGhost) added a project: Animation & Rigging.Dec 1 2020, 12:06 PM
Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Dec 1 2020, 1:14 PM
Christoph Lendenfeld (ChrisLend) requested changes to this revision.Dec 13 2020, 12:09 AM
Christoph Lendenfeld (ChrisLend) added a subscriber: Christoph Lendenfeld (ChrisLend).

the same check is also done in nla_eval_domain_action()
Any reason why we can't use the same function there?

This revision now requires changes to proceed.Dec 13 2020, 12:09 AM
Wayde Moss (GuiltyGhost) updated this revision to Diff 32225.Dec 21 2020, 9:44 PM
  • apply review note: apply is_fcurve_evaluatable() refactor to the rest of anim_sys.c
Harbormaster completed remote builds in B11847: Diff 32225.Dec 21 2020, 9:44 PM
Christoph Lendenfeld (ChrisLend) accepted this revision.Dec 22 2020, 9:05 PM

in that case it looks good to me

This revision is now accepted and ready to land.Dec 22 2020, 9:05 PM
Sybren A. Stüvel (sybren) added a reviewer: Animation & Rigging.Jan 8 2021, 2:45 PM

I'm adding Animation & Rigging as blocking reviewer, as per our module-specific review guidelines. Not that important, but it makes it possible to accept a patch on a personal note, without the entire patch going to "ACCEPTED" state immediately.

This revision now requires review to proceed.Jan 8 2021, 2:45 PM
Sybren A. Stüvel (sybren) accepted this revision.Jan 8 2021, 2:52 PM

LGTM, just a few tiny nags. Whether you include my way or your way of doing things I'll leave up to you @Wayde Moss (GuiltyGhost). Either way I'll accept the patch.

source/blender/blenkernel/intern/anim_sys.c
370

Superfluous parentheses can be removed around fcu->grp. If you want to make it more explicit, you can also write fcu->grp != NULL.

373–376

This is just return !BKE_fcurve_is_empty(fcu);

This revision is now accepted and ready to land.Jan 8 2021, 2:52 PM
Closed by commit rB32e4ded24b6b: Nla Refactor: is_fcurve_evaluatable() (authored by Wayde Moss (GuiltyGhost)). · Explain WhyJan 15 2021, 12:48 AM
This revision was automatically updated to reflect the committed changes.
Wayde Moss (GuiltyGhost) marked 2 inline comments as done.
Wayde Moss (GuiltyGhost) added a commit: rB32e4ded24b6b: Nla Refactor: is_fcurve_evaluatable().

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
47 lines

Diff 32225

View Options

source/blender/blenkernel/intern/anim_sys.c

Loading...