Differential D9694

Nla Refactor: Blend functions explicit Div0 check
ClosedPublic
Actions

Authored by Wayde Moss (GuiltyGhost) on Dec 1 2020, 12:25 PM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rB7f6ffe9195c1: Nla Refactor: Blend functions explicit Div0 check

Summary

It's an explicit check to prevent division by zero if caller hasn't done the check. Future patch D8867: Feature: NLA Merge Strips will not use the nla remap function and thus not do the check.
This patch also replaces some float (==) equality checks with IS_EQF().

Split from D9247: Refactor: NLA Prep for D8296

Diff Detail

Repository

Branch

refactor2_div0_check (branched from master)

Build Status

Buildable 11486
Build 11486: arc lint + arc unit

Event Timeline

Wayde Moss (GuiltyGhost) created this revision.Dec 1 2020, 12:25 PM

Harbormaster completed remote builds in B11482: Diff 31487.Dec 1 2020, 12:25 PM

Wayde Moss (GuiltyGhost) requested review of this revision.Dec 1 2020, 12:25 PM

Wayde Moss (GuiltyGhost) added a project: Animation & Rigging.Dec 1 2020, 12:25 PM

- nla blend inverse functions to do influence=0
- nla better naming for lower stack values, upper strip value, and blended value.

Harbormaster completed remote builds in B11484: Diff 31489.Dec 1 2020, 12:35 PM

Wayde Moss (GuiltyGhost) mentioned this in D9695: Nla Refactor: Better blend function parm naming.Dec 1 2020, 12:54 PM

revert last change: accidentally overwrote this patch with D9695

Harbormaster completed remote builds in B11486: Diff 31491.Dec 1 2020, 12:59 PM

Sybren A. Stüvel (sybren) accepted this revision.Dec 3 2020, 2:19 PM

This revision is now accepted and ready to land.Dec 3 2020, 2:19 PM

Closed by commit rB7f6ffe9195c1: Nla Refactor: Blend functions explicit Div0 check (authored by Wayde Moss (GuiltyGhost)). · Explain WhyDec 14 2020, 11:40 PM

This revision was automatically updated to reflect the committed changes.

Wayde Moss (GuiltyGhost) added a commit: rB7f6ffe9195c1: Nla Refactor: Blend functions explicit Div0 check.

Wayde Moss (GuiltyGhost) mentioned this in rB2d6e6d035b66: Nla Refactor: Better blend function parm naming.Dec 21 2020, 8:13 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

33 lines

Diff 31491

source/blender/blenkernel/intern/anim_sys.c

Loading...